linux-kernel - Re: [PATCH v2] scsi: ufs: core: Add ufshcd_send_bsg_uic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afe477c2276a932588af53e37945ea57b61effcf.camel@mediatek.com>
Date: Tue, 19 Nov 2024 09:22:30 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "quic_rampraka@...cinc.com" <quic_rampraka@...cinc.com>,
	"quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>,
	"quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
	"quic_ziqichen@...cinc.com" <quic_ziqichen@...cinc.com>, "beanhuo@...ron.com"
	<beanhuo@...ron.com>, "avri.altman@....com" <avri.altman@....com>,
	"bvanassche@....org" <bvanassche@....org>, "quic_asutoshd@...cinc.com"
	<quic_asutoshd@...cinc.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "junwoo80.lee@...sung.com"
	<junwoo80.lee@...sung.com>, "mani@...nel.org" <mani@...nel.org>,
	"quic_cang@...cinc.com" <quic_cang@...cinc.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dlemoal@...nel.org" <dlemoal@...nel.org>, "ahalaney@...hat.com"
	<ahalaney@...hat.com>, "quic_mnaresh@...cinc.com" <quic_mnaresh@...cinc.com>,
	"hare@...e.de" <hare@...e.de>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH v2] scsi: ufs: core: Add ufshcd_send_bsg_uic_cmd() for UFS
 BSG

On Tue, 2024-11-19 at 16:52 +0800, Ziqi Chen wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Hi Peter,
> 
> Thank you for your comment. We also recognize that the H8 Enter/Exit
> has
> the same issue. In fact, we have tried to add the H8 command before.
> Unfortunately, the situation with Hibern8 is complex, there are a lot
> of
> status checks, and some vendors have their own sequence that is
> implemented in their vendor driver by Vops. Simply including the H8
> command here would cause other issues since the vendor sequence for
> H8
> enter/exit is required. If we add the full sequence here, the code
> will
> be bloated. We haven’t come up with a good solution for the Hibern8
> situation yet. However, whether we include the H8 command or not, the
> above issue is present as well (directly call ufshcd_send_uic_cmd()
> via
> BSG framework).
> Right now, we have tested the PA_PWRMODE case and confirmed that it
> works, so we want to quickly resolve the PA_PWRMODE issue to unblock
> our
> customers’ urgent cases first. As for the Hibern8 situation, we have
> plan to fix it but we want to fix it afterward, in a separated
> change.
> If you have any good suggestions, we can discuss separately.
> 
> BRs,
> Ziqi
> 

Hi Ziqi,

I can understand.

Thanks.
Peter

Reviewed-by: Peter Wang <peter.wang@...iatek.com>