linux-kernel - Re: [PATCH v2 RESEND] drm/virtio: use generic dumb_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c842e7b-5a49-404d-9647-311bfc37f003@collabora.com>
Date: Tue, 19 Nov 2024 13:09:21 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Peter Shkenev <mustela@...inea.space>, David Airlie <airlied@...hat.com>,
 Gerd Hoffmann <kraxel@...hat.com>,
 Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu
 <olvaffe@...il.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Simona Vetter <simona@...ll.ch>, dri-devel@...ts.freedesktop.org,
 virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND] drm/virtio: use generic dumb_map_offset
 implementation

On 11/7/24 17:10, Peter Shkenev wrote:
> Currently, virtio uses its own dumb_map_offset implementation,
> virtio_gpu_mode_dumb_mmap. It works similarly to generic implementation,
> drm_gem_dumb_map_offset, and using the generic implementation is
> preferable (and making drivers to do so is a task stated on the DRM
> subsystem's TODO list).
> 
> Thus, make driver use the generic implementation. This includes
> VIRTGPU_MAP ioctl so it cannot be used to circumvent rules imposed by
> drm_gem_dumb_map_offset (imported objects cannot be mapped).
> 
> Signed-off-by: Peter Shkenev <mustela@...inea.space>
> ---
> Changes in v2:
>   - Remove excessive include of drm_gem.h from virtgpu_ioctl.h
>   - Remove obsoleted virtio_gpu_mode_dumb_mmap prototype from
>     virtgpu_drv.h
> 

Applied to misc-next, thanks!

-- 
Best regards,
Dmitry