linux-kernel - [PATCH bpf v3 0/2] bpf: enhance validation of pointer formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241119102214.2145-1-rabbelkin@mail.ru>
Date: Tue, 19 Nov 2024 10:22:11 +0000
From: Ilya Shchipletsov <rabbelkin@...l.ru>
To: bpf@...r.kernel.org
Cc: Ilya Shchipletsov <rabbelkin@...l.ru>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>,
	Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Florent Revest <revest@...omium.org>,
	Nikita Marushkin <hfggklm@...il.com>,
	lvc-project@...uxtesting.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH bpf v3 0/2] bpf: enhance validation of pointer formatting

This patch series enhances validation of pointer formatting to prevent same
exact issue happening again, as it happen before in [0] and happened now.

[0]: https://lkml.kernel.org/netdev/85a08645-453b-78ad-e401-55d2894fa64a@iogearbox.net/T/

Co-developed-by: Nikita Marushkin <hfggklm@...il.com>
Signed-off-by: Nikita Marushkin <hfggklm@...il.com>
Signed-off-by: Ilya Shchipletsov <rabbelkin@...l.ru>
---
Changes in v3:
- Resend due to odd "Changes Requested" status in Patchwork, although
  there've been no additional comments posted on mailing lists explaining
  that status.
- Add Yonghong's and Florent's ACKs.
- Link to v2: https://lore.kernel.org/bpf/20241028195343.2104-1-rabbelkin@mail.ru/
Changes in v2:
- Added Reported-by for syzbot [Florent Revest]
- Added negative tests for snprintf [Florent Revest]
- Moved comment to first 'if' statement [Yonghong Song]
- Link to v1: https://lore.kernel.org/bpf/9679a031-3858-4fef-bb8e-1cf436696095@mail.ru/
---
Ilya Shchipletsov (2):
  bpf: fix %p% runtime check in bpf_bprintf_prepare
  selftests/bpf: Add test cases for various pointer specifiers

 kernel/bpf/helpers.c                              | 13 +++++++++----
 tools/testing/selftests/bpf/prog_tests/snprintf.c | 15 +++++++++++++++
 2 files changed, 24 insertions(+), 4 deletions(-)
-- 
2.43.0