linux-kernel - Re: [PATCH] mailbox: Switch back to struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGb2v66f6WEYYVm+UQzmz_V87Vqt4BSUkoW5S_qqr_arczc6ug@mail.gmail.com>
Date: Tue, 19 Nov 2024 22:05:42 +0900
From: Chen-Yu Tsai <wens@...e.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Jassi Brar <jassisinghbrar@...il.com>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, 
	Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	Michal Simek <michal.simek@....com>, linux-kernel@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
	linux-arm-msm@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] mailbox: Switch back to struct platform_driver::remove()

On Tue, Nov 19, 2024 at 5:17 PM Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all platform drivers below drivers/mailbox to use .remove(),
> with the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
>
> Make a few indentions consistent while touching these struct
> initializers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Hello,
>
> I did a single patch for all of drivers/mailbox. While I usually prefer
> to do one logical change per patch, this seems to be overengineering
> here as the individual changes are really trivial and shouldn't be much
> in the way for stable backports. But I'll happily split the patch if you
> prefer it split.
>
> This is based on today's next, if conflicts arise when you apply it at
> some later time and don't want to resolve them, feel free to just drop
> the changes to the conflicting files. I'll notice and followup at a
> later time then. Or ask me for a fixed resend.
>
> Best regards
> Uwe
>
>  drivers/mailbox/bcm-flexrm-mailbox.c    | 2 +-
>  drivers/mailbox/bcm-pdc-mailbox.c       | 2 +-
>  drivers/mailbox/imx-mailbox.c           | 2 +-
>  drivers/mailbox/mailbox-test.c          | 4 ++--
>  drivers/mailbox/mtk-cmdq-mailbox.c      | 2 +-
>  drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +-
>  drivers/mailbox/qcom-ipcc.c             | 2 +-
>  drivers/mailbox/stm32-ipcc.c            | 2 +-


>  drivers/mailbox/sun6i-msgbox.c          | 4 ++--

Acked-by: Chen-Yu Tsai <wens@...e.org>

>  drivers/mailbox/tegra-hsp.c             | 2 +-
>  drivers/mailbox/zynqmp-ipi-mailbox.c    | 2 +-
>  11 files changed, 13 insertions(+), 13 deletions(-)
>