linux-kernel - Re: [PATCH v1] i2c-mlxbf: Add repeated start condition support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ji23yczfp75vtu7sp7pots66lr63mxbtkxea27lvc5id5tmfk3@pltlopcoz55c>
Date: Tue, 19 Nov 2024 14:45:46 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Chris Babroski <cbabroski@...dia.com>
Cc: kblaiech@...dia.com, asmaa@...dia.com, davthompson@...dia.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] i2c-mlxbf: Add repeated start condition support

Hi Chris,

On Mon, Nov 18, 2024 at 07:28:33PM +0000, Chris Babroski wrote:
> Add support for SMBus repeated start conditions to the Mellanox I2C
> driver. This support is specifically enabled for the
> I2C_FUNC_SMBUS_WRITE_I2C_BLOCK implementation which is required for
> communication with various I2C devices on Bluefield 3.
> 
> The I2C bus timing configuration values have also been updated based on
> latest HW testing results and found to be necessary to support repeated
> start transactions.
> 
> Signed-off-by: Chris Babroski <cbabroski@...dia.com>
> Reviewed-by: Asmaa Mnebhi <asmaa@...dia.com>
> Reviewed-by: Khalil Blaiech <kblaiech@...dia.com>

Where did these reviews take place? How is it possible that this
patch, at its v1, already has two reviews?

Please ensure everything happens openly on the mailing list. I
will need to ask Asmaa and Khalil to restate their Reviewed-by
tags here, as they carry very little weight when included by
default in a v1 patch.

Thanks,
Andi