linux-kernel - Re: [PATCH 1/2] hwmon: (sht3x) add devicetree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <419a5d2c-7d00-41c7-b787-c824b13dcce3@kernel.org>
Date: Tue, 19 Nov 2024 15:13:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: JuenKit Yip <hunterteaegg@....com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, jdelvare@...e.com, linux@...ck-us.net,
 peteryin.openbmc@...il.com, noahwang.wang@...look.com, festevam@...il.com,
 marex@...x.de, lukas@...ner.de, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (sht3x) add devicetree support

On 19/11/2024 15:07, JuenKit Yip wrote:
> add "compatible" property for supporting devicetree
> 
> Signed-off-by: JuenKit Yip <hunterteaegg@....com>
> ---
>  drivers/hwmon/sht3x.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
> index 650b0bcc2359..2ac1537b3e3e 100644
> --- a/drivers/hwmon/sht3x.c
> +++ b/drivers/hwmon/sht3x.c
> @@ -954,6 +954,19 @@ static int sht3x_probe(struct i2c_client *client)
>  	return PTR_ERR_OR_ZERO(hwmon_dev);
>  }
>  
> +/* devicetree ID table */
> +static const struct of_device_id sht3x_of_match[] = {
> +	{ .compatible = "sensirion,sht30", .data = (void *)sht3x },
This does not match your binding at all. Also all SHT/STS devices are
compatible, so express it in the binding with a fallback.

Anyway, you cannot just send half of patch afterwards without resolving
previous comments. If this is v2, mark it as v2. If this is a resend,
mark it as RESEND.

See other examples on mailing lists (lore.kernel.org) and read
submitting patches document.

Best regards,
Krzysztof