linux-kernel - Re: [GIT PULL] KUnit update for Linux 6.13-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce995a53-7fbd-43a3-be4d-70fc57b07212@linuxfoundation.org>
Date: Tue, 19 Nov 2024 08:36:53 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Kuan-Wei Chiu <visitorckw@...il.com>, David Gow <davidgow@...gle.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, shuah <shuah@...nel.org>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Brendan Higgins <brendan.higgins@...ux.dev>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [GIT PULL] KUnit update for Linux 6.13-rc1

On 11/18/24 18:55, Kuan-Wei Chiu wrote:
> Hi Shuah,
> 
> On Mon, Nov 18, 2024 at 12:19:50PM -0700, Shuah Khan wrote:
>> Hi Linus,
>>
>> Please pull the following kunit update for Linux 6.13-rc1.
>>
>> kunit update for Linux 6.13-rc1
>>
>> -- fixes user-after-free (UAF) bug in kunit_init_suite()
>>
>> -- adds option to kunit tool to print just the summary of test results
>>
>> -- adds option to kunit tool to print just the failed test results
>>
>> -- fixes kunit_zalloc_skb() to use user passed in gfp value instead of
>>     hardcoding GFP_KERNEL
>>
>> -- fixes kunit_zalloc_skb() kernel doc to include allocation flags variable
>>
>> diff is attached.
>>
>> Tests passed on my kunit repo:
>>
>> - Build make allmodconfig
>>
>> ./tools/testing/kunit/kunit.py run
>> ./tools/testing/kunit/kunit.py run --alltests
>>
>> ./tools/testing/kunit/kunit.py run --arch x86_64
>> ./tools/testing/kunit/kunit.py run --alltests --arch x86_64
>>
>> thanks,
>> -- Shuah
>>
>> ----------------------------------------------------------------
>> The following changes since commit 2d5404caa8c7bb5c4e0435f94b28834ae5456623:
>>
>>    Linux 6.12-rc7 (2024-11-10 14:19:35 -0800)
>>
>> are available in the Git repository at:
>>
>>    git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux_kselftest-kunit-6.13-rc1
>>
>> for you to fetch changes up to 67b6d342fb6d5abfbeb71e0f23141b9b96cf7bb1:
>>
>>    kunit: tool: print failed tests only (2024-11-14 09:38:19 -0700)
>>
>> ----------------------------------------------------------------
>> linux_kselftest-kunit-6.13-rc1
>>
>> kunit update for Linux 6.13-rc1
>>
>> -- fixes user-after-free (UAF) bug in kunit_init_suite()
>>
>> -- adds option to kunit tool to print just the summary of test results
>>
>> -- adds option to kunit tool to print just the failed test results
>>
>> -- fixes kunit_zalloc_skb() to use user passed in gfp value instead of
>>     hardcoding GFP_KERNEL
>>
>> -- fixes kunit_zalloc_skb() kernel doc to include allocation flags variable
>>
>> ----------------------------------------------------------------
>> Dan Carpenter (2):
>>        kunit: skb: use "gfp" variable instead of hardcoding GFP_KERNEL
>>        kunit: skb: add gfp to kernel doc for kunit_zalloc_skb()
>>
>> David Gow (1):
>>        kunit: tool: Only print the summary
>>
>> Jinjie Ruan (1):
>>        kunit: string-stream: Fix a UAF bug in kunit_init_suite()
>>
> The patch [1] intended to address the UAF issue in kunit_init_suite()
> is not correct and does not actually fix the problem. A v2 patch [2]
> with the proper fix has been sent.
> 

Hmm. I picked this up because David reviewed it and added his
Reviewed-by. I would like David's feedback on which patch we
should be taking.

> 
> [1]: https://lore.kernel.org/lkml/20241024094303.1531810-1-ruanjinjie@huawei.com
> [2]: https://lore.kernel.org/linux-kselftest/20241112080314.407966-1-ruanjinjie@huawei.com

David, Can you take you let me know. I don't mind redoing the PR
for Linus. I just have to know which patch to take.

thanks,
-- Shuah