linux-kernel - Re: [PATCH v5 2/9] riscv: dts: Add display property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241120-ricotta-rescuer-90bad7c38e93@spud>
Date: Wed, 20 Nov 2024 16:48:47 +0000
From: Conor Dooley <conor@...nel.org>
To: keith zhao <keith.zhao@...rfivetech.com>
Cc: devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	andrzej.hajda@...el.com, neil.armstrong@...aro.org,
	rfoss@...nel.org, Laurent.pinchart@...asonboard.com,
	jonas@...boo.se, jernej.skrabec@...il.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	hjc@...k-chips.com, heiko@...ech.de, andy.yan@...k-chips.com,
	william.qiu@...rfivetech.com, xingyu.wu@...rfivetech.com,
	kernel@...il.dk, paul.walmsley@...ive.com, palmer@...belt.com,
	aou@...s.berkeley.edu, p.zabel@...gutronix.de,
	changhuang.liang@...rfivetech.com, jack.zhu@...rfivetech.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/9] riscv: dts: Add display property

On Wed, Nov 20, 2024 at 02:18:41PM +0800, keith zhao wrote:
> Add the display DT nodes in Starfive JH7110 soc-specific DT file.
> 
> Signed-off-by: keith zhao <keith.zhao@...rfivetech.com>

$subject: "riscv: dts: Add display property"

a) this is jh7110 exclusive, not for all riscv devicetrees
b) you are adding more than a property

> ---
>  .../boot/dts/starfive/jh7110-common.dtsi      | 125 ++++++++++++++++++
>  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  41 ++++++
>  2 files changed, 166 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 9d77713f5361..301b56f2ef0c 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -30,6 +30,25 @@ memory@...00000 {
>  		reg = <0x0 0x40000000 0x1 0x0>;
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		/* vout applies for space from this CMA

"vout" could be a voltage, please be more specific. Comments should be
wrapped at at least 80 chars. Linux coding style puts /* on a line of
its own.

> +		 * Without this CMA reservation,
> +		 * vout may not work properly.
> +		 */
> +		linux,cma {
> +			compatible = "shared-dma-pool";
> +			reusable;
> +			size = <0x0 0x20000000>;
> +			alignment = <0x0 0x1000>;
> +			alloc-ranges = <0x0 0x70000000 0x0 0x20000000>;
> +			linux,cma-default;
> +		};
> +	};
> +
>  	gpio-restart {
>  		compatible = "gpio-restart";
>  		gpios = <&sysgpio 35 GPIO_ACTIVE_HIGH>;
> @@ -62,12 +81,55 @@ codec {
>  			};
>  		};
>  	};
> +
> +	hdmi_con: hdmi-con {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
>  };
>  
>  &cpus {
>  	timebase-frequency = <4000000>;
>  };
>  
> +&dc8200 {
> +	status = "okay";
> +	crtc_out: ports {

blank line between properties and child nodes please.

> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		dc_out0: port@0 {

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)