[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7a52ca1f-303e-44ae-b750-6aaa521516c3@linaro.org>
Date: Wed, 20 Nov 2024 17:09:08 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Bjorn Andersson <andersson@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: gdsc: Add pm_runtime hooks
On 19/11/2024 15:34, Bjorn Andersson wrote:
> What I think you want is two things:
> 1) When you're accessing the registers, you want the clock controller's
> power-domain to be on.
> 2) When the client vote for a GDSC, you want to have the PM framework
> also ensure that parent power-domains are kept on.
> For the single case, this is handled by the pm_genpd_add_subdomain()
> call below. This, or something along those lines, seems like the
> appropriate solution.
Yes.
I'm finding with this patch reverted but, keeping the first patch that
it pretty much works as you'd want with the caveat that gdsc_register ->
gdsc_en -> gdsc_toggle fails the first time.
After that I see the GDSCs on/off as excpected
cat /sys/kernel/debug/pm_genpd/cam_cc_titan_top_gdsc/current_state
off-0
cat /sys/kernel/debug/pm_genpd/cam_cc_ife_0_gdsc/current_state
off-0
cam -c 1 --capture=10 --file
cat /sys/kernel/debug/pm_genpd/cam_cc_titan_top_gdsc/current_state
off-0
cat /sys/kernel/debug/pm_genpd/cam_cc_ife_0_gdsc/current_state
off-0
Perhaps we just need to fix the probe path @ gdsc_register()
---
bod
Powered by blists - more mailing lists