linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for adp1051, adp1055 and ltp8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfe8e47e-6c31-4b11-b733-38e5bd0e49d3@kernel.org>
Date: Wed, 20 Nov 2024 18:35:33 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Conor Dooley <conor@...nel.org>,
 Cedric Encarnacion <cedricjustine.encarnacion@...log.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-hwmon@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
 Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Radu Sabau <radu.sabau@...log.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Alexis Czezar Torreno <alexisczezar.torreno@...log.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for
 adp1051, adp1055 and ltp8800

On 20/11/2024 18:11, Conor Dooley wrote:
> On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote:
>> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus.
>>     ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
>>     ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
>>     LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
>>
>> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
>> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
>> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@...log.com>
> 
> Why did you drop my ack?
> https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/
So that's a v2? Or v3? Then should be marked correctly. Please start
using b4. I already asked analog.com for this in few cases. Feel free
not to use b4 if you send correct patches, but this is not the case here.

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18



Best regards,
Krzysztof