linux-kernel - Re: [PATCH] staging:gpib: Fix a dereference before null check issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ca90e87-965a-4895-ba72-8144540f6e4c@ijzerbout.nl>
Date: Wed, 20 Nov 2024 20:54:16 +0100
From: Kees Bakker <kees@...erbout.nl>
To: Dan Carpenter <dan.carpenter@...aro.org>, Paolo Perego <pperego@...e.de>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Dave Penkler <dpenkler@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] staging:gpib: Fix a dereference before null check issue

Op 20-11-2024 om 18:04 schreef Dan Carpenter:
> On Wed, Nov 20, 2024 at 03:46:53PM +0100, Paolo Perego wrote:
>> This commit fixes a dereference before null check issue discovered by
>> Coverity (CID 1601566).
>>
>> The check ad line 1450 suggests that a_priv can be NULL, however it has
>> been derefenced before, in the interface_to_usbdev() call.
>>
>> Signed-off-by: Paolo Perego <pperego@...e.de>
>> ---
> You need a Fixes tag.  But I'm pretty sure the correct fix is to remove the NULL
> check.
In the whole agilent_82357a.c module there is no consistency whether
board->private_data needs to be checked for a NULL or not.

If Dan is correct then it is better to drop the NULL check, not only here
but in a few more places as well. There are at least 10 functions were
there is no NULL check for private_data.

Run this command and you'll see what I mean
git grep -3 -e '->private_data' -- drivers/staging/gpib/agilent_82357a

>
> regards,
> dan carpenter
>