linux-kernel - Re: [PATCH v9 01/26] x86/resctrl: Add __init attribute for the functions called in resctrl_late

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55237d27-16dd-4b0d-868a-bc7ca6155270@amd.com>
Date: Wed, 20 Nov 2024 14:02:23 -0600
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: fenghua.yu@...el.com, x86@...nel.org, hpa@...or.com, thuth@...hat.com,
 paulmck@...nel.org, rostedt@...dmis.org, akpm@...ux-foundation.org,
 xiongwei.song@...driver.com, pawan.kumar.gupta@...ux.intel.com,
 daniel.sneddon@...ux.intel.com, perry.yuan@....com, sandipan.das@....com,
 kai.huang@...el.com, xiaoyao.li@...el.com, seanjc@...gle.com,
 jithu.joseph@...el.com, brijesh.singh@....com, xin3.li@...el.com,
 ebiggers@...gle.com, andrew.cooper3@...rix.com, mario.limonciello@....com,
 james.morse@....com, tan.shaopeng@...itsu.com, tony.luck@...el.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 peternewman@...gle.com, maciej.wieczor-retman@...el.com, eranian@...gle.com,
 jpoimboe@...nel.org, thomas.lendacky@....com
Subject: Re: [PATCH v9 01/26] x86/resctrl: Add __init attribute for the
 functions called in resctrl_late_init

Hi Reinette,

On 11/18/24 16:07, Reinette Chatre wrote:
> Hi Babu,
> 
> On 11/18/24 9:44 AM, Moger, Babu wrote:
>> Hi Reinette,
>>
>> On 11/15/24 17:21, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> In subject please use () to indicate a function, writing resctrl_late_init()
>>
>> Will change it to
>>
>> x86/resctrl: Add __init attribute for all the call sequences in
>> resctrl_late_init()
> 
> I am not sure how to interpret "call sequences". The original is ok now that
> cache_alloc_hsw_probe() is also included. Specifically, this can be:
> 
> 	x86/resctrl: Add __init attribute to functions called from resctrl_late_init()

Sure.
> 
>>
>>>
>>> On 10/29/24 4:21 PM, Babu Moger wrote:
>>>> The function resctrl_late_init() has the __init attribute, but some
>>>
>>> No need to say "The function" when using ().
>>>
>>>> functions it calls do not. Add the __init attribute to all the functions
>>>
>>> None of the functions changed are actually called by resctrl_late_init(). If this
>>> is indeed the goal then I think cache_alloc_hsw_probe() was missed.
>>
>> Will change the function to.
>>
>> static inline __init void cache_alloc_hsw_probe(void)
>>
>> How about this description?
>>
>> "resctrl_late_init() has the __init attribute, but some of the call
>> sequences of it do not have the __init attribute.
> 
> "some of the call sequences of it" sounds strange. It can be simplified with
> "some of the functions called from it"?

Sure,

> 
>>
>> Add the __init attribute to all the functions in the call sequences to
>> maintain consistency throughout."
> 
> Sounds good, thank you.

-- 
Thanks
Babu Moger