linux-kernel - Re: [PATCH v30 26/30] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd2dca5b-af57-43c7-b960-3908e1501f44@quicinc.com>
Date: Wed, 20 Nov 2024 14:10:35 -0800
From: Wesley Cheng <quic_wcheng@...cinc.com>
To: Takashi Iwai <tiwai@...e.de>
CC: <srinivas.kandagatla@...aro.org>, <mathias.nyman@...el.com>,
        <perex@...ex.cz>, <conor+dt@...nel.org>, <dmitry.torokhov@...il.com>,
        <corbet@....net>, <broonie@...nel.org>, <lgirdwood@...il.com>,
        <krzk+dt@...nel.org>, <pierre-louis.bossart@...ux.intel.com>,
        <Thinh.Nguyen@...opsys.com>, <tiwai@...e.com>, <robh@...nel.org>,
        <gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-sound@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-input@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v30 26/30] ALSA: usb-audio: qcom: Introduce QC USB SND
 offloading support

Hi Takashi,

On 11/20/2024 4:15 AM, Takashi Iwai wrote:
> On Wed, 06 Nov 2024 20:34:09 +0100,
> Wesley Cheng wrote:
>> +config SND_USB_AUDIO_QMI
>> +	tristate "Qualcomm Audio Offload driver"
>> +	depends on QCOM_QMI_HELPERS && SND_USB_AUDIO && USB_XHCI_SEC_INTR && SND_SOC_USB
>> +	select SND_PCM
> This select is superfluous as it already depends on
> CONFIG_SND_USB_AUDIO that does select it.
ACK.
>> diff --git a/sound/usb/qcom/Makefile b/sound/usb/qcom/Makefile
>> new file mode 100644
>> index 000000000000..a81c9b28d484
>> --- /dev/null
>> +++ b/sound/usb/qcom/Makefile
>> @@ -0,0 +1,2 @@
>> +snd-usb-audio-qmi-objs := usb_audio_qmi_v01.o qc_audio_offload.o
> Use snd-usb-audio-qmi-y instead of *-objs.
>
Will change this.

Thanks

Wesley Cheng