linux-kernel - Re: [PATCH 2/2] hwmon: (pmbus/adp1050): add support for adp1051, adp1055 and ltp8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c13b4dc-da2c-4548-910a-cf4138d8422a@infradead.org>
Date: Tue, 19 Nov 2024 21:00:28 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Cedric Encarnacion <cedricjustine.encarnacion@...log.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Cc: Guenter Roeck <linux@...ck-us.net>, Jean Delvare <jdelvare@...e.com>,
 Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Radu Sabau <radu.sabau@...log.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Alexis Czezar Torreno <alexisczezar.torreno@...log.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 2/2] hwmon: (pmbus/adp1050): add support for adp1051,
 adp1055 and ltp8800



On 11/19/24 7:58 PM, Cedric Encarnacion wrote:
>     ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
>     ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
>     LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
> 
> The LTP8800 is a family of step-down μModule regulators that provides
> microprocessor core voltage from 54V power distribution architecture.
> LTP8800 features telemetry monitoring of input/output voltage, input
> current, output power, and temperature over PMBus.
> 
> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@...log.com>
> ---
>  Documentation/hwmon/adp1050.rst | 63 +++++++++++++++++++++++++++--
>  drivers/hwmon/pmbus/Kconfig     |  9 +++++
>  drivers/hwmon/pmbus/adp1050.c   | 72 +++++++++++++++++++++++++++++++--
>  3 files changed, 137 insertions(+), 7 deletions(-)
> 

> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index f6d352841953..5d03a307824e 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -67,6 +67,15 @@ config SENSORS_ADP1050
>  	  This driver can also be built as a module. If so, the module will
>  	  be called adp1050.
>  
> +config SENSORS_ADP1050_REGULATOR
> +	bool "Regulator support for ADP1050 and compatibles"
> +	depends on SENSORS_ADP1050 && REGULATOR
> +	help
> +	  If you say yes here you get regulator support for Analog Devices
> +	  LTP8800-1A, LTP8800-4A, and LTP8800-2. LTP8800 is a family of DC/DC
> +	  µModule regulators that can provide microprocessor power from 54V
> +	  power distribution architecture.
> +
>  config SENSORS_BEL_PFE
>  	tristate "Bel PFE Compatible Power Supplies"
>  	help

FYI:

The 'micro' symbol displays as a blank space in 'menuconfig' or 'nconfig'.
(It shows up correctly in gconfig and xconfig.)

This problem is not unique to this driver entry.
See https://lore.kernel.org/all/20231006202942.GA865945@bhelgaas/ from 2023.

AFAIK no one is working on this issue.
Feel free to change the help text or leave it...

-- 
~Randy