linux-kernel - Re: [PATCH v2 07/21] arm64: dts: ti: k3-am62: New GPU binding details

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7974001-227e-4224-a895-21be5a1a3e3a@kernel.org>
Date: Wed, 20 Nov 2024 09:32:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matt Coster <matt.coster@...tec.com>, Frank Binns
 <frank.binns@...tec.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
 Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Randolph Sapp <rs@...com>, Darren Etheridge <detheridge@...com>
Subject: Re: [PATCH v2 07/21] arm64: dts: ti: k3-am62: New GPU binding details

On 18/11/2024 14:01, Matt Coster wrote:
> Use the new compatible string introduced earlier (in "dt-bindings: gpu:
> img: More explicit compatible strings") and add a name to the single power
> domain for this GPU (introduced in "dt-bindings: gpu: img: Power domain
> details").
> 
> Signed-off-by: Matt Coster <matt.coster@...tec.com>
> ---
> Changes in v2:
> - None
> - Link to v1: https://lore.kernel.org/r/20241105-sets-bxs-4-64-patch-v1-v1-7-4ed30e865892@imgtec.com

Do not mix DTS with code. It always goes either to end of patchset or
entirely separate.

To be clear: this cannot be merged into DRM.


> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 5b92aef5b284b78749a01d44184b66e7776a124d..93dcc67c3138ad5b4a7ad6c9bcabb71a2b7e408d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -693,12 +693,13 @@ ospi0: spi@...0000 {
>  	};
>  
>  	gpu: gpu@...0000 {
> -		compatible = "ti,am62-gpu", "img,img-axe";
> +		compatible = "ti,am62-gpu", "img,img-axe-1-16m", "img,img-rogue";

Definitely NAK, breaks users and nothing in commit msg provides any help
on that, including why or how it affects potential users.


Best regards,
Krzysztof