linux-kernel - Re: [PATCH] wifi: cfg80211: fix WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b28eb973d42b680db268eda1868b672264ab12be.camel@sipsolutions.net>
Date: Wed, 20 Nov 2024 09:59:38 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Aditya Kumar Singh <quic_adisi@...cinc.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: fix WARN_ON during CAC cancelling

On Tue, 2024-11-19 at 11:23 +0530, Aditya Kumar Singh wrote:
> 
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -5046,10 +5046,11 @@ static void ieee80211_del_intf_link(struct wiphy 
> *wiphy,
>                                      unsigned int link_id)
>   {
>          struct ieee80211_sub_if_data *sdata = 
> IEEE80211_WDEV_TO_SUB_IF(wdev);
> +       u16 new_links = wdev->valid_links & ~BIT(link_id);
> 
>          lockdep_assert_wiphy(sdata->local->hw.wiphy);
> 
> -       ieee80211_vif_set_links(sdata, wdev->valid_links, 0);
> +       ieee80211_vif_set_links(sdata, new_links, 0);
>   }

Needing this part is sort of clear then, but maybe not entirely obvious?
Should probably be accompanied by some documentation updates.

> So I will submit this as patch then?

Seems reasonable.

> > There's necessarily going to be some temporary inconsistency here, I'm
> > not sure it matters too much if it isn't very visible?
> > 
> 
> Any particular case you suspect and want me to test?

No, not really.

> I'm more inclining towards the first suggestion you gave - clearing the 
> bitmap later. What's your suggestion?
> 

Sure.

johannes