linux-kernel - Re: [PATCH 11/15] ARM: dts: microchip: add sama7d65 SoC DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ishcitppbc7asngzpp5dl3htkitxpeu3dgtmz44swcg2h7dmup@zc2etw2hrsbg>
Date: Wed, 20 Nov 2024 10:10:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ryan.Wanner@...rochip.com
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com, claudiu.beznea@...on.dev, 
	mturquette@...libre.com, sboyd@...nel.org, arnd@...db.de, dharma.b@...rochip.com, 
	mihai.sain@...rochip.com, romain.sioen@...rochip.com, varshini.rajendran@...rochip.com, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, linux-mmc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-spi@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 11/15] ARM: dts: microchip: add sama7d65 SoC DT

On Tue, Nov 19, 2024 at 09:40:17AM -0700, Ryan.Wanner@...rochip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@...rochip.com>
> 
> Add Device Tree for sama7d65 SoC.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>
> Co-developed-by: Romain Sioen <romain.sioen@...rochip.com>
> Signed-off-by: Romain Sioen <romain.sioen@...rochip.com>
> Co-developed-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> Signed-off-by: Dharma Balasubiramani <dharma.b@...rochip.com>

Totally confusing SoB chain. Please read carefully submitting patches.

...

> +	clocks {
> +		slow_xtal: clock-slowxtal {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +		};
> +
> +		main_xtal: clock-mainxtal {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +		};
> +	};
> +
> +	vddout25: fixed-regulator-vddout25 {

s/fixed-//

> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "VDDOUT25";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-boot-on;
> +		status = "disabled";
> +	};
> +
> +	soc {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		pioA: pinctrl@...14000 {

labels are lowercase.

Best regards,
Krzysztof