[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <613460f0.9d25.19348ee14f1.Coremail.00107082@163.com>
Date: Wed, 20 Nov 2024 17:36:22 +0800 (CST)
From: "David Wang" <00107082@....com>
To: "Geert Uytterhoeven" <geert@...ux-m68k.org>
Cc: tglx@...utronix.de, linux-kernel@...r.kernel.org,
linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 01/13] kernel/irq/proc: use seq_put_decimal_ull_width()
for decimal values
At 2024-11-20 17:00:38, "Geert Uytterhoeven" <geert@...ux-m68k.org> wrote:
>Hi David,
>
>>
>> Several drivers use dev_name as format string for seq_printf, would this raise security concerns?
>>
>> drivers/gpio/gpio-xgs-iproc.c: seq_printf(p, dev_name(chip->dev));
>> drivers/gpio/gpio-mlxbf2.c: seq_printf(p, dev_name(gs->dev));
>> drivers/gpio/gpio-omap.c: seq_printf(p, dev_name(bank->dev));
>> drivers/gpio/gpio-hlwd.c: seq_printf(p, dev_name(hlwd->dev));
>> drivers/gpio/gpio-aspeed.c: seq_printf(p, dev_name(gpio->dev));
>> drivers/gpio/gpio-pca953x.c: seq_printf(p, dev_name(gc->parent));
>> drivers/gpio/gpio-tegra186.c: seq_printf(p, dev_name(gc->parent));
>> drivers/gpio/gpio-tegra.c: seq_printf(s, dev_name(chip->parent));
>> drivers/gpio/gpio-ep93xx.c: seq_printf(p, dev_name(gc->parent));
>> drivers/gpio/gpio-aspeed-sgpio.c: seq_printf(p, dev_name(gpio->dev));
>> drivers/gpio/gpio-pl061.c: seq_printf(p, dev_name(gc->parent));
>> drivers/gpio/gpio-visconti.c: seq_printf(p, dev_name(priv->dev));
>
>In theory, yes. But I guess it's hard to sneak a percent sign in these
>device names.
Yes, it is just theoretical... (Would be a wonderful story if someone manage it somehow :) )
Anyway, I send out another patch for further discussion.
>
>But given the above, all of them should probably be updated to print
>an initial space?
>
Oh, no, I did not mean to adding leading space for those in irq_print_chip()
I mentioned those just because of the format string thing.
Add leading space in those irq_print_chip() is kind of strange...
With Thomas's patch, irq_print_chip() needs not worry about the leading space issue.
>Gr{oetje,eeting}s,
>
> Geert
>
>--
>Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
>In personal conversations with technical people, I call myself a hacker. But
>when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Thanks~
David
Powered by blists - more mailing lists