linux-kernel - [PATCH] ARM: smp: Fix IPI alignment in /proc/interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <96f61cafee969c59796ac06c1410195fa0f1ba0b.1732096154.git.geert+renesas@glider.be>
Date: Wed, 20 Nov 2024 10:54:53 +0100
From: Geert Uytterhoeven <geert+renesas@...der.be>
To: Russell King <linux@...linux.org.uk>,
	Thomas Gleixner <tglx@...utronix.de>
Cc: linux-arm-kernel@...ts.infradead.org,
	linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: [PATCH] ARM: smp: Fix IPI alignment in /proc/interrupts

On a system with less than 1000 interrupts, prec = 3, causing a
misalignment for the IPI interrupts.  E.g. on Koelsch (R-Car M2-W):

    200:          0          0  gpio-rcar   6 Edge      SW36
    IPI0:          0          0  CPU wakeup interrupts
    IPI1:          0          0  Timer broadcast interrupts
    IPI2:       1701       2844  Rescheduling interrupts
    IPI3:      10338      21181  Function call interrupts
    IPI4:          0          0  CPU stop interrupts
    IPI5:        651        825  IRQ work interrupts
    IPI6:          0          0  completion interrupts
    Err:          0

Fix this by adopting the same solution as used on arm64.

Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
---
 arch/arm/kernel/smp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 3431c0553f45cdf5..50999886a8b5cbab 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -551,7 +551,8 @@ void show_ipi_list(struct seq_file *p, int prec)
 		if (!ipi_desc[i])
 			continue;
 
-		seq_printf(p, "%*s%u: ", prec - 1, "IPI", i);
+		seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
+			   prec >= 4 ? " " : "");
 
 		for_each_online_cpu(cpu)
 			seq_printf(p, "%10u ", irq_desc_kstat_cpu(ipi_desc[i], cpu));
-- 
2.34.1