| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241120095923.1891-5-shiju.jose@huawei.com>
Date: Wed, 20 Nov 2024 09:59:14 +0000
From: <shiju.jose@...wei.com>
To: <linux-edac@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
<mchehab@...nel.org>, <dave.jiang@...el.com>, <dan.j.williams@...el.com>,
<jonathan.cameron@...wei.com>, <alison.schofield@...el.com>,
<nifan.cxl@...il.com>, <vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
<dave@...olabs.net>
CC: <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
<tanxiaofei@...wei.com>, <prime.zeng@...ilicon.com>, <shiju.jose@...wei.com>
Subject: [PATCH 04/13] rasdaemon: cxl: Update common event to CXL spec rev 3.1
From: Shiju Jose <shiju.jose@...wei.com>
CXL spec 3.1 section 8.2.9.2.1 Table 8-42, Common Event Record format has
updated with Maintenance Operation Subclass information.
Add updates in rasdaemon CXL event handler for the above spec change
and for the corresponding changes in kernel CXL common trace event
implementation.
Signed-off-by: Shiju Jose <shiju.jose@...wei.com>
---
ras-cxl-handler.c | 10 +++++++++-
ras-record.c | 5 +++++
ras-record.h | 1 +
ras-report.c | 6 ++++--
4 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/ras-cxl-handler.c b/ras-cxl-handler.c
index 7d4fc9f..d16eaef 100644
--- a/ras-cxl-handler.c
+++ b/ras-cxl-handler.c
@@ -575,18 +575,20 @@ int ras_cxl_overflow_event_handler(struct trace_seq *s,
/*
* Common Event Record Format
- * CXL 3.0 section 8.2.9.2.1; Table 8-42
+ * CXL 3.1 section 8.2.9.2.1; Table 8-43
*/
#define CXL_EVENT_RECORD_FLAG_PERMANENT BIT(2)
#define CXL_EVENT_RECORD_FLAG_MAINT_NEEDED BIT(3)
#define CXL_EVENT_RECORD_FLAG_PERF_DEGRADED BIT(4)
#define CXL_EVENT_RECORD_FLAG_HW_REPLACE BIT(5)
+#define CXL_EVENT_RECORD_FLAG_MAINT_OP_SUB_CLASS_VALID BIT(6)
static const struct cxl_event_flags cxl_hdr_flags[] = {
{ .bit = CXL_EVENT_RECORD_FLAG_PERMANENT, .flag = "PERMANENT_CONDITION" },
{ .bit = CXL_EVENT_RECORD_FLAG_MAINT_NEEDED, .flag = "MAINTENANCE_NEEDED" },
{ .bit = CXL_EVENT_RECORD_FLAG_PERF_DEGRADED, .flag = "PERFORMANCE_DEGRADED" },
{ .bit = CXL_EVENT_RECORD_FLAG_HW_REPLACE, .flag = "HARDWARE_REPLACEMENT_NEEDED" },
+ { .bit = CXL_EVENT_RECORD_FLAG_MAINT_OP_SUB_CLASS_VALID, .flag = "MAINT_OP_SUB_CLASS_VALID" },
};
static int handle_ras_cxl_common_hdr(struct trace_seq *s,
@@ -670,6 +672,12 @@ static int handle_ras_cxl_common_hdr(struct trace_seq *s,
if (trace_seq_printf(s, "hdr_maint_op_class:%u ", hdr->hdr_maint_op_class) <= 0)
return -1;
+ if (tep_get_field_val(s, event, "hdr_maint_op_sub_class", record, &val, 1) < 0)
+ return -1;
+ hdr->hdr_maint_op_sub_class = val;
+ if (trace_seq_printf(s, "hdr_maint_op_sub_class:%u ", hdr->hdr_maint_op_sub_class) <= 0)
+ return -1;
+
return 0;
}
diff --git a/ras-record.c b/ras-record.c
index 9e68158..b52973f 100644
--- a/ras-record.c
+++ b/ras-record.c
@@ -797,6 +797,7 @@ static int ras_store_cxl_common_hdr(sqlite3_stmt *stmt, struct ras_cxl_event_com
sqlite3_bind_text(stmt, idx++, hdr->hdr_timestamp, -1, NULL);
sqlite3_bind_int(stmt, idx++, hdr->hdr_length);
sqlite3_bind_int(stmt, idx++, hdr->hdr_maint_op_class);
+ sqlite3_bind_int(stmt, idx++, hdr->hdr_maint_op_sub_class);
return idx;
}
@@ -818,6 +819,7 @@ static const struct db_fields cxl_generic_event_fields[] = {
{ .name = "hdr_ts", .type = "TEXT" },
{ .name = "hdr_length", .type = "INTEGER" },
{ .name = "hdr_maint_op_class", .type = "INTEGER" },
+ { .name = "hdr_maint_op_sub_class", .type = "INTEGER" },
{ .name = "data", .type = "BLOB" },
};
@@ -873,6 +875,7 @@ static const struct db_fields cxl_general_media_event_fields[] = {
{ .name = "hdr_ts", .type = "TEXT" },
{ .name = "hdr_length", .type = "INTEGER" },
{ .name = "hdr_maint_op_class", .type = "INTEGER" },
+ { .name = "hdr_maint_op_sub_class", .type = "INTEGER" },
{ .name = "dpa", .type = "INTEGER" },
{ .name = "dpa_flags", .type = "INTEGER" },
{ .name = "descriptor", .type = "INTEGER" },
@@ -952,6 +955,7 @@ static const struct db_fields cxl_dram_event_fields[] = {
{ .name = "hdr_ts", .type = "TEXT" },
{ .name = "hdr_length", .type = "INTEGER" },
{ .name = "hdr_maint_op_class", .type = "INTEGER" },
+ { .name = "hdr_maint_op_sub_class", .type = "INTEGER" },
{ .name = "dpa", .type = "INTEGER" },
{ .name = "dpa_flags", .type = "INTEGER" },
{ .name = "descriptor", .type = "INTEGER" },
@@ -1038,6 +1042,7 @@ static const struct db_fields cxl_memory_module_event_fields[] = {
{ .name = "hdr_ts", .type = "TEXT" },
{ .name = "hdr_length", .type = "INTEGER" },
{ .name = "hdr_maint_op_class", .type = "INTEGER" },
+ { .name = "hdr_maint_op_sub_class", .type = "INTEGER" },
{ .name = "event_type", .type = "INTEGER" },
{ .name = "health_status", .type = "INTEGER" },
{ .name = "media_status", .type = "INTEGER" },
diff --git a/ras-record.h b/ras-record.h
index cd549a1..2a0124a 100644
--- a/ras-record.h
+++ b/ras-record.h
@@ -179,6 +179,7 @@ struct ras_cxl_event_common_hdr {
char hdr_timestamp[64];
uint8_t hdr_length;
uint8_t hdr_maint_op_class;
+ uint8_t hdr_maint_op_sub_class;
};
struct ras_cxl_generic_event {
diff --git a/ras-report.c b/ras-report.c
index bc77d04..7e974b9 100644
--- a/ras-report.c
+++ b/ras-report.c
@@ -507,7 +507,8 @@ static int set_cxl_generic_event_backtrace(char *buf, struct ras_cxl_generic_eve
"hdr_related_handle=0x%x\n"
"hdr_timestamp=%s\n"
"hdr_length=%u\n"
- "hdr_maint_op_class=%u\n",
+ "hdr_maint_op_class=%u\n"
+ "hdr_maint_op_sub_class=%u\n",
ev->hdr.timestamp,
ev->hdr.memdev,
ev->hdr.host,
@@ -519,7 +520,8 @@ static int set_cxl_generic_event_backtrace(char *buf, struct ras_cxl_generic_eve
ev->hdr.hdr_related_handle,
ev->hdr.hdr_timestamp,
ev->hdr.hdr_length,
- ev->hdr.hdr_maint_op_class);
+ ev->hdr.hdr_maint_op_class,
+ ev->hdr.hdr_maint_op_sub_class);
return 0;
}
--
2.43.0
Powered by blists - more mailing lists