linux-kernel - Re: [PATCH] seqlock: annotate spinning as unlikely() in __read_seqcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241120-gastgewerbe-oblag-e8e208731117@brauner>
Date: Wed, 20 Nov 2024 12:11:45 +0100
From: Christian Brauner <brauner@...nel.org>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: Christian Brauner <brauner@...nel.org>,
	linux-kernel@...r.kernel.org,
	peterz@...radead.org
Subject: Re: [PATCH] seqlock: annotate spinning as unlikely() in __read_seqcount_begin

On Thu, 27 Jul 2023 20:03:55 +0200, Mateusz Guzik wrote:
> Annotation already used to be there, but got lost in 52ac39e5db5148f7
> ("seqlock: seqcount_t: Implement all read APIs as statement expressions").
> Does not look like it was intentional.
> 
> Without it gcc 12 decides to compile the following in path_init:
>         nd->m_seq = __read_seqcount_begin(&mount_lock.seqcount);
>         nd->r_seq = __read_seqcount_begin(&rename_lock.seqcount);
> 
> [...]

Applied to the vfs-6.14.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.14.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.14.misc

[1/1] seqlock: annotate spinning as unlikely() in __read_seqcount_begin
      https://git.kernel.org/vfs/vfs/c/c795e8ac8471