linux-kernel - Re: [PATCH v1] tmpfs: Unsigned expression compared with zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72e793e3-e31e-4caa-b2a8-96886036964b@igalia.com>
Date: Wed, 20 Nov 2024 08:10:54 -0300
From: André Almeida <andrealmeid@...lia.com>
To: guanjing <guanjing@...s.chinamobile.com>
Cc: linux-fsdevel@...r.kernel.org, krisman@...nel.org, tytso@....edu,
 brauner@...nel.org, akpm@...ux-foundation.org, hughd@...gle.com,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v1] tmpfs: Unsigned expression compared with zero

Hi guanjing,

Em 20/11/2024 07:51, guanjing escreveu:
> The return value from the call to utf8_parse_version() is not
> of the unsigned type.
> 
> However, the return value is being assigned to an unsigned int
> variable 'version'. This will result in the inability to handle
> errors that occur when parsing a UTF-8 version number from
> a string.
> 
> Additionally, this patch can help eliminate the following
> Coccicheck warning:
> 
> mm/shmem.c:4378:6-13: WARNING: Unsigned expression compared with zero: version < 0
> 
> Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
> Signed-off-by: guanjing <guanjing@...s.chinamobile.com>

Another fix was already sent: 
https://lore.kernel.org/lkml/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com/