[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Zz3M1Ji-n1XIi9UX@e110455-lin.cambridge.arm.com>
Date: Wed, 20 Nov 2024 11:49:40 +0000
From: Liviu Dudau <liviu.dudau@....com>
To: Boris Brezillon <boris.brezillon@...labora.com>
Cc: Steven Price <steven.price@....com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c
On Wed, Nov 20, 2024 at 12:41:25PM +0100, Boris Brezillon wrote:
> On Tue, 19 Nov 2024 16:44:55 +0000
> Liviu Dudau <liviu.dudau@....com> wrote:
>
> > Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot
> > to copy the definition of glb_iface when it move one line of code.
> >
> > Fixes: Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path")
> > Signed-off-by: Liviu Dudau <liviu.dudau@....com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>
>
> Liviu, can you queue this patch to drm-misc if that's not already done?
Thanks, pushed to drm-misc-next, as that's where Karunika's patch landed.
Best regards,
Liviu
>
> > ---
> > drivers/gpu/drm/panthor/panthor_fw.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> > index 4bc52b1b1a286..c807b6ce71bd4 100644
> > --- a/drivers/gpu/drm/panthor/panthor_fw.c
> > +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> > @@ -1133,6 +1133,7 @@ int panthor_fw_post_reset(struct panthor_device *ptdev)
> > * This is not needed on a slow reset because FW sections are
> > * re-initialized.
> > */
> > + struct panthor_fw_global_iface *glb_iface = panthor_fw_get_glb_iface(ptdev);
> > panthor_fw_update_reqs(glb_iface, req, 0, GLB_HALT);
> >
> > ret = panthor_fw_start(ptdev);
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
Powered by blists - more mailing lists