linux-kernel - Re: [PATCH v2 2/2] ipmi: ssif_bmc: add GPIO-based alert mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2441bab-304b-4983-8780-43671e8add4b@os.amperecomputing.com>
Date: Wed, 20 Nov 2024 08:58:47 +0700
From: Quan Nguyen <quan@...amperecomputing.com>
To: Corey Minyard <corey@...yard.net>
Cc: Potin Lai <potin.lai.pt@...il.com>, Corey Minyard <minyard@....org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Patrick Williams <patrick@...cx.xyz>,
 openipmi-developer@...ts.sourceforge.net, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Cosmo Chou <cosmo.chou@...ntatw.com>,
 Potin Lai <potin.lai@...ntatw.com>, Cosmo Chou <chou.cosmo@...il.com>
Subject: Re: [PATCH v2 2/2] ipmi: ssif_bmc: add GPIO-based alert mechanism



On 19/11/2024 18:30, Corey Minyard wrote:
> On Wed, Oct 23, 2024 at 11:30 PM Quan Nguyen
> <quan@...amperecomputing.com> wrote:
>>
>>
>>
>> On 22/10/2024 08:20, Potin Lai wrote:
>>> From: Cosmo Chou <chou.cosmo@...il.com>
>>>
>>> Implement GPIO-based alert mechanism in the SSIF BMC driver to notify
>>> the host when a response is ready.
>>>
>>> This improves host-BMC communication efficiency by providing immediate
>>> notification, potentially reducing host polling overhead.
>>>
>>> Signed-off-by: Cosmo Chou <chou.cosmo@...il.com>
>>> ---
>>>    drivers/char/ipmi/ssif_bmc.c | 15 +++++++++++++++
>>>    1 file changed, 15 insertions(+)
>>>
>>
>> Thanks for adding feature to this driver, the code looks good to me.
>>
>> Reviewed-by: Quan Nguyen <quan@...amperecomputing.com>
>>
>> I'm just have a bit of curious on how the ipmi_ssif in host side to work
>> with this mechanism? Will there be patches for ipmi_ssif to use this
>> feature followed?
> 
> I just saw this.  What makes you think alerts are not supported in ipmi_ssif?
> 

Yes, Corey, I see alerts are supported in ipmi_ssif.

My apology about the unclear question, I was just curious about whether 
this gpio-based alerts mechanism is confirmed through test with current 
ipmi_ssif without any extra patches.

Thanks,
- Quan