linux-kernel - Re: [PATCH v3] usb: dwc3: remove unused sg struct member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zz3vdkEzSobJ54bI@x13>
Date: Wed, 20 Nov 2024 09:17:26 -0500
From: Luis Felipe Hernandez <luis.hernandez093@...il.com>
To: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"rbm@...e.com" <rbm@...e.com>,
	"skhan@...uxfoundation.org" <skhan@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel-mentees@...ts.linuxfoundation.org" <linux-kernel-mentees@...ts.linuxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] usb: dwc3: remove unused sg struct member

Thanks, Thinh and Greg, for the feedback!

On Tue, Nov 19, 2024 at 10:19:09PM +0000, Thinh Nguyen wrote:
> > Previously, this patch addressed a documentation warning caused by the
> 
> Remove this paragraph. This context only makes sense in this thread
> where the previous patch version is visible.
> 

I’ll update the commit message and remove the unnecessary paragraph as suggested.

> > Reported-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
> 
> I'm not the one who should be attributed to by the Reported-by tag.
> 
> I think Greg was alluding to this report by Stephen Rothwell:
> https://lore.kernel.org/all/20241118194006.77c7b126@canb.auug.org.au/
> 
> It wasn't Cc to the linux-usb list, so I'm not sure if you've seen it.
> If your change was base on the report above, then you can update the
> Reported-by tag accordingly.
> 

Regarding the report by Stephen Rothwell, I wasn’t aware of it before. I found the warning independently while trying to compile the Documentation subsystem, looking for bugs to address.

That said, now that I’m aware of Stephen’s thread, I wouldn’t mind updating the commit message to include a reference to it if you think it would help link the two discussions. Let me know your thoughts on this.

Thanks again for the clarification and the reviews!

Best,

Felipe