linux-kernel - Re: [PATCH 2/2] hwmon: (pmbus/adp1050): add support for adp1051, adp1055 and ltp8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1b338a0-fe51-48a1-a35e-41041df79b63@roeck-us.net>
Date: Wed, 20 Nov 2024 06:39:38 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Cedric Encarnacion <cedricjustine.encarnacion@...log.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Cc: Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Radu Sabau <radu.sabau@...log.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Alexis Czezar Torreno <alexisczezar.torreno@...log.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 2/2] hwmon: (pmbus/adp1050): add support for adp1051,
 adp1055 and ltp8800

On 11/19/24 19:58, Cedric Encarnacion wrote:
>      ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
>      ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
>      LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
> 
> The LTP8800 is a family of step-down μModule regulators that provides
> microprocessor core voltage from 54V power distribution architecture.
> LTP8800 features telemetry monitoring of input/output voltage, input
> current, output power, and temperature over PMBus.
> 
> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@...log.com>
> ---
>   Documentation/hwmon/adp1050.rst | 63 +++++++++++++++++++++++++++--
>   drivers/hwmon/pmbus/Kconfig     |  9 +++++
>   drivers/hwmon/pmbus/adp1050.c   | 72 +++++++++++++++++++++++++++++++--
>   3 files changed, 137 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/hwmon/adp1050.rst b/Documentation/hwmon/adp1050.rst
> index 8fa937064886..1692373ee5af 100644
> --- a/Documentation/hwmon/adp1050.rst
> +++ b/Documentation/hwmon/adp1050.rst
> @@ -13,18 +13,43 @@ Supported chips:
>   
>       Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ADP1050.pdf
>   
> +  * Analog Devices ADP1051
> +
> +    Prefix: 'adp1051'
> +
> +    Addresses scanned: I2C 0x70 - 0x77
> +
> +    Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ADP1051.pdf
> +
> +  * Analog Devices ADP1055
> +
> +    Prefix: 'adp1055'
> +
> +    Addresses scanned: I2C 0x4B - 0x77
> +
> +    Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ADP1055.pdf
> +
> +  * Analog Devices LTP8800-1A/-2/-4A
> +
> +    Prefix: 'ltp8800'
> +
> +    Addresses scanned: -
> +
> +    Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/LTP8800-1A.pdf
> +         https://www.analog.com/media/en/technical-documentation/data-sheets/LTP8800-2.pdf
> +         https://www.analog.com/media/en/technical-documentation/data-sheets/LTP8800-4A.pdf
> +
>   Authors:
>   
>     - Radu Sabau <radu.sabau@...log.com>
>   
> -

Unrelated

>   Description
>   -----------
>   
> -This driver supprts hardware monitoring for Analog Devices ADP1050 Digital
> -Controller for Isolated Power Supply with PMBus interface.
> +This driver supports hardware monitoring for Analog Devices ADP1050, ADP1051, and
> +ADP1055 Digital Controller for Isolated Power Supply with PMBus interface.
>   
> -The ADP1050 is an advanced digital controller with a PMBus™
> +The ADP105X is an advanced digital controller with a PMBus™

Please refrain from using device name wildcards, There is no guarantee that
all chips in the name range of ADP105[0-9] will have the same functionality.
Either name the chips, or say something like "The supported chips are ...".

Guenter