linux-kernel - Re: [PATCH] ftrace: Fix regression with module command in stack_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241120095225.37fe4655@gandalf.local.home>
Date: Wed, 20 Nov 2024 09:52:25 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: guoweikang <guoweikang.kernel@...il.com>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland
 <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] ftrace: Fix regression with module command in
 stack_trace_filter

On Wed, 20 Nov 2024 13:27:49 +0800
guoweikang <guoweikang.kernel@...il.com> wrote:

> When executing the following command:
> 
>     # echo "write*:mod:ext3" > /sys/kernel/tracing/stack_trace_filter
> 
> The current mod command causes a null pointer dereference. While commit
> 0f17976568b3f ("ftrace: Fix regression with module command in stack_trace_filter")
> has addressed part of the issue, it left a corner case unhandled, which still
> results in a kernel crash.

Ouch!

Thanks, I'll also mark this as stable.

-- Steve

> 
> Signed-off-by: guoweikang <guoweikang.kernel@...il.com>
> ---
>  kernel/trace/ftrace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 71e53eaba8bc..9b17efb1a87d 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -5093,6 +5093,9 @@ ftrace_mod_callback(struct trace_array *tr, struct ftrace_hash *hash,
>  	char *func;
>  	int ret;
>  
> +	if (!tr)
> +		return -ENODEV;
> +
>  	/* match_records() modifies func, and we need the original */
>  	func = kstrdup(func_orig, GFP_KERNEL);
>  	if (!func)