linux-kernel - Re: [RFCv1 0/6] Page Detective

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmgxvs81.fsf@linux.intel.com>
Date: Wed, 20 Nov 2024 07:29:34 -0800
From: Andi Kleen <ak@...ux.intel.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: linux-kernel@...r.kernel.org,  linux-mm@...ck.org,
  linux-doc@...r.kernel.org,  linux-fsdevel@...r.kernel.org,
  cgroups@...r.kernel.org,  linux-kselftest@...r.kernel.org,
  akpm@...ux-foundation.org,  corbet@....net,  derek.kiernan@....com,
  dragan.cvetic@....com,  arnd@...db.de,  gregkh@...uxfoundation.org,
  viro@...iv.linux.org.uk,  brauner@...nel.org,  jack@...e.cz,
  tj@...nel.org,  hannes@...xchg.org,  mhocko@...nel.org,
  roman.gushchin@...ux.dev,  shakeel.butt@...ux.dev,
  muchun.song@...ux.dev,  Liam.Howlett@...cle.com,
  lorenzo.stoakes@...cle.com,  vbabka@...e.cz,  jannh@...gle.com,
  shuah@...nel.org,  vegard.nossum@...cle.com,  vattunuru@...vell.com,
  schalla@...vell.com,  david@...hat.com,  willy@...radead.org,
  osalvador@...e.de,  usama.anjum@...labora.com,  andrii@...nel.org,
  ryan.roberts@....com,  peterx@...hat.com,  oleg@...hat.com,  tandersen@
Subject: Re: [RFCv1 0/6] Page Detective

Pasha Tatashin <pasha.tatashin@...een.com> writes:

> Page Detective is a new kernel debugging tool that provides detailed
> information about the usage and mapping of physical memory pages.
>
> It is often known that a particular page is corrupted, but it is hard to
> extract more information about such a page from live system. Examples
> are:
>
> - Checksum failure during live migration
> - Filesystem journal failure
> - dump_page warnings on the console log
> - Unexcpected segfaults
>
> Page Detective helps to extract more information from the kernel, so it
> can be used by developers to root cause the associated problem.
>
> It operates through the Linux debugfs interface, with two files: "virt"
> and "phys".
>
> The "virt" file takes a virtual address and PID and outputs information
> about the corresponding page.
>
> The "phys" file takes a physical address and outputs information about
> that page.
>
> The output is presented via kernel log messages (can be accessed with
> dmesg), and includes information such as the page's reference count,
> mapping, flags, and memory cgroup. It also shows whether the page is
> mapped in the kernel page table, and if so, how many times.

A lot of all that is already covered in /proc/kpage{flags,cgroup,count)
Also we already have /proc/pid/pagemap to resolve virtual addresses.

At a minimum you need to discuss why these existing mechanisms are not
suitable for you and how your new one is better.

If something particular is missing perhaps the existing mechanisms
can be extended?

Outputting in the dmesg seems rather clumpsy for a production mechanism.

I personally would just use live crash or live gdb on /proc/kcore to get
extra information, although I can see that might have races.

-Andi