linux-kernel - Re: [PATCH v4 2/3] scsi: ufs: core: Introduce a new clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55ab06af-ff92-4454-b9d2-d481d8e9db43@acm.org>
Date: Thu, 21 Nov 2024 13:14:10 -0800
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <Avri.Altman@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Bean Huo <beanhuo@...ron.com>
Subject: Re: [PATCH v4 2/3] scsi: ufs: core: Introduce a new clock_gating lock

On 11/21/24 1:06 PM, Avri Altman wrote:
>> On 11/18/24 6:41 AM, Avri Altman wrote:
>>> +     spin_lock_irqsave(hba->host->host_lock, flags);
>>> +     if (ufshcd_has_pending_tasks(hba) ||
>>> +         hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL) {
>>> +             spin_unlock_irqrestore(hba->host->host_lock, flags);
>>> +             return;
>>> +     }
>>> +     spin_unlock_irqrestore(hba->host->host_lock, flags);
>>
>> Why explicit lock/unlock calls instead of using scoped_guard()?
> Should I apply those to host_lock as well?

Yes, please use scoped_guard() and guard() in new code. I expect that
using scoped_guard() here will lead to code that is easier to read.

>>> + * @clk_gating_workq: workqueue for clock gating work.
>>> + * @lock: serialize access to some struct ufs_clk_gating members
>>
>> Please document that @lock is the outer lock relative to the host lock.
> Not sure what you mean?
> host_lock is nested in one place only, should this goes to the @lock documentation?

Whenever locks are nested, the nesting order must be consistent
everywhere. Otherwise there is a risk of triggering an ABBA deadlock.
So I think it is a good practice to document in which order locks should
be nested.

Thanks,

Bart.