linux-kernel - Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zz-9vviSWP8oRPUx@wunner.de>
Date: Fri, 22 Nov 2024 00:09:50 +0100
From: Lukas Wunner <lukas@...ner.de>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Shuai Xue <xueshuai@...ux.alibaba.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, bhelgaas@...gle.com,
	tony.luck@...el.com, bp@...en8.de, mhiramat@...nel.org,
	mathieu.desnoyers@...icios.com, oleg@...hat.com, naveen@...nel.org,
	davem@...emloft.net, anil.s.keshavamurthy@...el.com,
	mark.rutland@....com, peterz@...radead.org
Subject: Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for
 hotplug event

On Thu, Nov 21, 2024 at 08:43:54AM -0500, Steven Rostedt wrote:
> On Thu, 21 Nov 2024 19:34:31 +0800
> Shuai Xue <xueshuai@...ux.alibaba.com> wrote:
> > Sure, I can reorganize the directory. You have two optional proposals:
> > 
> > 1. /sys/kernel/debug/tracing/events/pci_hp_event
> > 2. /sys/kernel/debug/tracing/events/pci/pci_hp_event
> > 
> > I personally prefer the second approach.
[...]
> That said, is all these events going to be related to hotplug? If so, you
> probably want "hotplug" or "hp" in the system name. If you make it just
> "pci", then it will be expected that all the events will be related to PCI
> in general.

Grouping them under "pci" probably makes more sense than grouping them
under "hotplug".  A lot can be hotplugged (cpu, memory, PCI, USB, ...)
but it's mostly unrelated hardware and enabling all their events at once
doesn't seem to make much sense.  Whereas I can imagine people want to
enable all PCI trace events.  We currently only have tracepoints for AER
in the PCI core, but perhaps people will want to add new ones for
power faults, DPC recovery, bandwidth control etc.

Would something like

  /sys/kernel/debug/tracing/events/pci/hotplug_event

be possible?  It would seem more elegant than

  /sys/kernel/debug/tracing/events/pci/pci_hp_event

because it avoids the duplication of "pci" in the path.

Thanks,

Lukas