lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6e1fa7cc-c80b-40c1-aee5-d2e954ae1513@quicinc.com>
Date: Thu, 21 Nov 2024 11:54:21 +0530
From: Ekansh Gupta <quic_ekangupt@...cinc.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: <srinivas.kandagatla@...aro.org>, <linux-arm-msm@...r.kernel.org>,
        <quic_bkumar@...cinc.com>, <linux-kernel@...r.kernel.org>,
        <quic_chennak@...cinc.com>, <dri-devel@...ts.freedesktop.org>,
        <arnd@...db.de>
Subject: Re: [PATCH v1 2/4] misc: fastrpc: Rename fastrpc.c to fastrpc_main.c



On 11/18/2024 7:28 PM, Greg KH wrote:
> On Mon, Nov 18, 2024 at 02:10:44PM +0530, Ekansh Gupta wrote:
>> Rename the main fastrpc source file to accomodate new files to be
>> compiled in the same kernel object.
>>
>> Signed-off-by: Ekansh Gupta <quic_ekangupt@...cinc.com>
>> ---
>>  drivers/misc/fastrpc/Makefile                      | 1 +
>>  drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} | 0
>>  2 files changed, 1 insertion(+)
>>  rename drivers/misc/fastrpc/{fastrpc.c => fastrpc_main.c} (100%)
>>
>> diff --git a/drivers/misc/fastrpc/Makefile b/drivers/misc/fastrpc/Makefile
>> index 77fd2b763b6b..020d30789a80 100644
>> --- a/drivers/misc/fastrpc/Makefile
>> +++ b/drivers/misc/fastrpc/Makefile
>> @@ -1,2 +1,3 @@
>>  # SPDX-License-Identifier: GPL-2.0
>>  obj-$(CONFIG_QCOM_FASTRPC)	+= fastrpc.o
>> +fastrpc-objs	:= fastrpc_main.o
>> \ No newline at end of file
>> diff --git a/drivers/misc/fastrpc/fastrpc.c b/drivers/misc/fastrpc/fastrpc_main.c
>> similarity index 100%
>> rename from drivers/misc/fastrpc/fastrpc.c
>> rename to drivers/misc/fastrpc/fastrpc_main.c
> Why not just "main.c"?  You are in your own subdir, no need for the
> fastrpc_* prefix anymore, right?
Ack. I will update the names in next patchset. Thanks.

--ekansh
> thanks,
>
> greg "naming is hard" k-h


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ