linux-kernel - RE: [PATCH v2] bpftool: fix potential NULL pointer dereferencing in prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <673ed487b45f4_157a208ab@john.notmuch>
Date: Wed, 20 Nov 2024 22:34:47 -0800
From: John Fastabend <john.fastabend@...il.com>
To: Amir Mohammadi <amirmohammadi1999.am@...il.com>, 
 qmo@...nel.org, 
 ast@...nel.org, 
 daniel@...earbox.net, 
 andrii@...nel.org, 
 martin.lau@...ux.dev, 
 eddyz87@...il.com, 
 song@...nel.org, 
 yonghong.song@...ux.dev, 
 john.fastabend@...il.com, 
 kpsingh@...nel.org, 
 sdf@...ichev.me, 
 haoluo@...gle.com, 
 jolsa@...nel.org, 
 bpf@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Cc: Amir Mohammadi <amiremohamadi@...oo.com>
Subject: RE: [PATCH v2] bpftool: fix potential NULL pointer dereferencing in
 prog_dump()

Amir Mohammadi wrote:
> A NULL pointer dereference could occur if ksyms
> is not properly checked before usage in the prog_dump() function.
> 
> Signed-off-by: Amir Mohammadi <amiremohamadi@...oo.com>
> ---
>  tools/bpf/bpftool/prog.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)

LGTM but still needs a Fixes line.