linux-kernel - RE: [PATCH v1] selftests/bpf: Fix unnecessary conversion to bool in 'run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <673ed56061103_157a208bc@john.notmuch>
Date: Wed, 20 Nov 2024 22:38:24 -0800
From: John Fastabend <john.fastabend@...il.com>
To: guanjing <guanjing@...s.chinamobile.com>, 
 andrii@...nel.org, 
 eddyz87@...il.com, 
 mykolal@...com, 
 ast@...nel.org, 
 daniel@...earbox.net, 
 martin.lau@...ux.dev, 
 song@...nel.org, 
 yonghong.song@...ux.dev, 
 john.fastabend@...il.com, 
 kpsingh@...nel.org, 
 sdf@...ichev.me, 
 haoluo@...gle.com, 
 jolsa@...nel.org, 
 shuah@...nel.org
Cc: bpf@...r.kernel.org, 
 linux-kselftest@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 guanjing <guanjing@...s.chinamobile.com>
Subject: RE: [PATCH v1] selftests/bpf: Fix unnecessary conversion to bool in
 'run_subtest'

guanjing wrote:
> Fixes the following coccicheck:
> 
> tools/testing/selftests/bpf/test_loader.c:1033:64-69: WARNING: conversion to bool not needed here
> 
> Fixes: 80a4129fcf20 ("selftests/bpf: Add unit tests for bpf_arena_alloc/free_pages")
> Signed-off-by: guanjing <guanjing@...s.chinamobile.com>
> ---

I'll argue this is bpf-next and no need for a fixes tag here.

>  tools/testing/selftests/bpf/test_loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_loader.c b/tools/testing/selftests/bpf/test_loader.c
> index 3e9b009580d4..400f56f81272 100644
> --- a/tools/testing/selftests/bpf/test_loader.c
> +++ b/tools/testing/selftests/bpf/test_loader.c
> @@ -1030,7 +1030,7 @@ void run_subtest(struct test_loader *tester,
>  		}
>  
>  		do_prog_test_run(bpf_program__fd(tprog), &retval,
> -				 bpf_program__type(tprog) == BPF_PROG_TYPE_SYSCALL ? true : false);
> +				 bpf_program__type(tprog) == BPF_PROG_TYPE_SYSCALL);
>  		if (retval != subspec->retval && subspec->retval != POINTER_VALUE) {
>  			PRINT_FAIL("Unexpected retval: %d != %d\n", retval, subspec->retval);
>  			goto tobj_cleanup;
> -- 
> 2.33.0
> 
> 
>