linux-kernel - Re: [PATCH v5 3/8] virtio: hookup irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eae15480-403a-45c8-a8d0-4a34339d6b36@oracle.com>
Date: Thu, 21 Nov 2024 09:01:49 +0000
From: John Garry <john.g.garry@...cle.com>
To: Daniel Wagner <wagi@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Eugenio Pérez <eperezma@...hat.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hannes Reinecke <hare@...e.de>, Ming Lei <ming.lei@...hat.com>
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, virtualization@...ts.linux.dev,
        linux-scsi@...r.kernel.org, megaraidlinux.pdl@...adcom.com,
        mpi3mr-linuxdrv.pdl@...adcom.com, MPT-FusionLinux.pdl@...adcom.com,
        storagedev@...rochip.com, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v5 3/8] virtio: hookup irq_get_affinity callback

On 15/11/2024 16:37, Daniel Wagner wrote:
> Reviewed-by: Christoph Hellwig<hch@....de>
> Reviewed-by: Hannes Reinecke<hare@...e.de>
> Reviewed-by: Ming Lei<ming.lei@...hat.com>
> Signed-off-by: Daniel Wagner<wagi@...nel.org>

Reviewed-by: John Garry <john.g.garry@...cle.com>

> ---
>   drivers/virtio/virtio.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index b9095751e43bb7db5fc991b0cc0979d2e86f7b9b..4ca6ec84cb092eac7ddf4b86b4eacac099b480cf 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -377,6 +377,24 @@ static void virtio_dev_remove(struct device *_d)
>   	of_node_put(dev->dev.of_node);
>   }
>   
> +/**

nit: does this really need to be kerneldoc, as it is static?

> + * virtio_irq_get_affinity - get IRQ affinity mask for device
> + * @_d: ptr to dev structure
> + * @irq_vec: interrupt vector number
> + *
> + * Return the CPU affinity mask for @_d and @irq_vec.
> + */
> +static const struct cpumask *virtio_irq_get_affinity(struct device *_d,
> +						     unsigned int irq_vec)
> +{
> +	struct virtio_device *dev = dev_to_virtio(_d);
> +
> +	if (!dev->config->get_vq_affinity)
> +		return NULL;
> +
> +	return dev->config->get_vq_affinity(dev, irq_vec);
> +}
> +
>   static const struct bus_type virtio_bus = {