linux-kernel - Re: [PATCH v2] firewall: remove misplaced semicolon fromstm32_firewall_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bee10978-ce12-4813-957d-2d1288f49815@cmss.chinamobile.com>
Date: Thu, 21 Nov 2024 17:19:37 +0800
From: guanjing <guanjing@...s.chinamobile.com>
To: Gatien CHEVALLIER <gatien.chevallier@...s.st.com>,
 Alexandre TORGUE <alexandre.torgue@...s.st.com>, mcoquelin.stm32@...il.com
Cc: linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] firewall: remove misplaced semicolon
 fromstm32_firewall_get_firewall

Thanks for your advice. I apologize for the omission. :)


On 2024/11/12 17:40, Gatien CHEVALLIER wrote:
> On 11/12/24 10:25, Alexandre TORGUE wrote:
>> Hi
>>
>> On 11/9/24 06:50, guanjing wrote:
>>> Remove misplaced colon in stm32_firewall_get_firewall()
>>> which results in a syntax error when the code is compiled
>>> without CONFIG_STM32_FIREWALL.
>>>
>>> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
>>> Signed-off-by: guanjing <guanjing@...s.chinamobile.com>
>>> ---
>>>   include/linux/bus/stm32_firewall_device.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/bus/stm32_firewall_device.h 
>>> b/include/linux/bus/stm32_firewall_device.h
>>> index 18e0a2fc3816..5178b72bc920 100644
>>> --- a/include/linux/bus/stm32_firewall_device.h
>>> +++ b/include/linux/bus/stm32_firewall_device.h
>>> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct 
>>> stm32_firewall *firewall, u32 su
>>>   #else /* CONFIG_STM32_FIREWALL */
>>>   int stm32_firewall_get_firewall(struct device_node *np, struct 
>>> stm32_firewall *firewall,
>>> -                unsigned int nb_firewall);
>>> +                unsigned int nb_firewall)
>>>   {
>>>       return -ENODEV;
>>>   }
>>
>> Acked-by: Alexandre Torgue <alexandre.torgue@...s.st.com>
>>
>> Thanks
>> Alex
>
> Hi, please use get_maintainers.pl script next time so that
> adequate people are put in To/CC.
> Nevertheless, thanks for the patch!
>
> Reviewed-by: Gatien Chevallier <gatien.chevallier@...s.st.com>