lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <26392a7f-82c6-4b7b-829e-76f3d78115d1@linaro.org>
Date: Thu, 21 Nov 2024 11:01:32 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Xin Liu <quic_liuxin@...cinc.com>, Krzysztof Kozlowski <krzk@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Avri Altman <avri.altman@....com>, Bart Van Assche <bvanassche@....org>,
 Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
 quic_jiegan@...cinc.com, quic_aiquny@...cinc.com, quic_tingweiz@...cinc.com,
 quic_sayalil@...cinc.com
Subject: Re: [PATCH v2 1/3] dt-bindings: ufs: qcom: Add UFS Host Controller
 for QCS615

On 21/11/2024 09:37, Xin Liu wrote:
> 
> 
> 在 2024/11/21 15:40, Krzysztof Kozlowski 写道:
>> On 20/11/2024 17:57, Krzysztof Kozlowski wrote:
>>> On 19/11/2024 03:20, Xin Liu wrote:
>>>> From: Sayali Lokhande <quic_sayalil@...cinc.com>
>>>>
>>>> Document the Universal Flash Storage(UFS) Host Controller on the Qualcomm
>>>> QCS615 Platform.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>>>> Signed-off-by: Sayali Lokhande <quic_sayalil@...cinc.com>
>>>> Co-developed-by: Xin Liu <quic_liuxin@...cinc.com>
>>>> Signed-off-by: Xin Liu <quic_liuxin@...cinc.com>
>>> That's a bit odd SoB chain. First, these are just one-liners. Second,
>>> who authored the patches?
>> To be clear: SoB regarding authorship is correct, but regarding Acks and
>> Reviews is not. Savali did not receive these tags. If so, please point
>> to lore discussion with it.
>>
>> All this needs fixing.
> Thank you for your comments. These are the two reviews I received. One 
> is your reviewd-by, and the other is Manivannan's acked-by.I have also 
> cc Sayali on the email.
> 
> https://lore.kernel.org/linux-arm-msm/rv3ukz6rhgp3x32s74nbftmoqmdxjxmoii3zsd4wipmhudyq7q@ha4l2svl5lim/
> 
> https://lore.kernel.org/linux-arm-msm/20241112075619.2ilsccnnk4leqmdy@thinkpad/

I meant order of tags. Who received them? You, not Sayali. Then they
cannot be before Sayali SoB.


Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ