linux-kernel - Re: [PATCH v2] perf/arm-cmn: Ensure port and device id bits are set properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7636597-b72e-4bea-ab07-c6ad6caf2aac@arm.com>
Date: Thu, 21 Nov 2024 10:08:35 +0000
From: Robin Murphy <robin.murphy@....com>
To: Namhyung Kim <namhyung@...nel.org>, Will Deacon <will@...nel.org>,
 Mark Rutland <mark.rutland@....com>
Cc: Stephane Eranian <eranian@...gle.com>, LKML
 <linux-kernel@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] perf/arm-cmn: Ensure port and device id bits are set
 properly

On 2024-11-21 12:13 am, Namhyung Kim wrote:
> The portid_bits and deviceid_bits were set only for XP type nodes in
> the arm_cmn_discover() and it confused other nodes to find XP nodes.
> Copy the both bits from the XP nodes directly when it sets up a new
> node.

Reviewed-by: Robin Murphy <robin.murphy@....com>

> Fixes: e79634b53e39 ("perf/arm-cmn: Refactor node ID handling. Again.")
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>   drivers/perf/arm-cmn.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 49bd811c6fd6efdd..b20fa600e510c54f 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -2178,8 +2178,6 @@ static int arm_cmn_init_dtcs(struct arm_cmn *cmn)
>   			continue;
>   
>   		xp = arm_cmn_node_to_xp(cmn, dn);
> -		dn->portid_bits = xp->portid_bits;
> -		dn->deviceid_bits = xp->deviceid_bits;
>   		dn->dtc = xp->dtc;
>   		dn->dtm = xp->dtm;
>   		if (cmn->multi_dtm)
> @@ -2420,6 +2418,8 @@ static int arm_cmn_discover(struct arm_cmn *cmn, unsigned int rgn_offset)
>   			}
>   
>   			arm_cmn_init_node_info(cmn, reg & CMN_CHILD_NODE_ADDR, dn);
> +			dn->portid_bits = xp->portid_bits;
> +			dn->deviceid_bits = xp->deviceid_bits;
>   
>   			switch (dn->type) {
>   			case CMN_TYPE_DTC:
> 
> base-commit: 43fb83c17ba2d63dfb798f0be7453ed55ca3f9c2