linux-kernel - Re: [PATCH] drm/sti: Add __iomem for mixer_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3e3b5b4-1b67-4564-ab3e-da7a073f45ec@gmail.com>
Date: Thu, 21 Nov 2024 12:18:44 +0100
From: Raphaël Gallais-Pou <rgallaispou@...il.com>
To: Pei Xiao <xiaopei01@...inos.cn>, alain.volmat@...s.st.com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, --to=lkp@...el.com
Cc: ville.syrjala@...ux.intel.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drm/sti: Add __iomem for mixer_dbg_mxn's parameter



> Sparse complains about incorrect type in argument 1.
> expected void const volatile  __iomem *ptr but got void *.
> so modify mixer_dbg_mxn's addr parameter.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411191809.6V3c826r-lkp@intel.com/
> Fixes: a5f81078a56c ("drm/sti: add debugfs entries for MIXER crtc")
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
Hi,

Thanks for your fix.

Acked-by: Raphael Gallais-Pou <rgallaispou@...il.com>

Regards,
Raphaël
> ---
>   drivers/gpu/drm/sti/sti_mixer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c
> index 7e5f14646625..06c1b81912f7 100644
> --- a/drivers/gpu/drm/sti/sti_mixer.c
> +++ b/drivers/gpu/drm/sti/sti_mixer.c
> @@ -137,7 +137,7 @@ static void mixer_dbg_crb(struct seq_file *s, int val)
>   	}
>   }
>   
> -static void mixer_dbg_mxn(struct seq_file *s, void *addr)
> +static void mixer_dbg_mxn(struct seq_file *s, void __iomem *addr)
>   {
>   	int i;
>