linux-kernel - Re: [PATCH] platform/x86: x86-android-tablets: make platform data be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd19d849-de80-4806-9757-b74bb373ad0e@redhat.com>
Date: Thu, 21 Nov 2024 13:32:20 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Pei Xiao <xiaopei01@...inos.cn>, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] platform/x86: x86-android-tablets: make platform data be
 static

Hi,

On 21-Nov-24 4:55 AM, Pei Xiao wrote:
> make lenovo_yoga_tab2_1380_bq24190_pdata and lenovo_yoga_tab2_1380_modules
> to be static
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410160432.oJAPbrW9-lkp@intel.com/
> Fixes: 3eee73ad42c3 ("platform/x86: x86-android-tablets: Add Lenovo Yoga Tablet 2 Pro 1380F/L data")
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans




> ---
>  drivers/platform/x86/x86-android-tablets/lenovo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/x86-android-tablets/lenovo.c b/drivers/platform/x86/x86-android-tablets/lenovo.c
> index ae087f1471c1..a60efbaf4817 100644
> --- a/drivers/platform/x86/x86-android-tablets/lenovo.c
> +++ b/drivers/platform/x86/x86-android-tablets/lenovo.c
> @@ -601,7 +601,7 @@ static const struct regulator_init_data lenovo_yoga_tab2_1380_bq24190_vbus_init_
>  	.num_consumer_supplies = 1,
>  };
>  
> -struct bq24190_platform_data lenovo_yoga_tab2_1380_bq24190_pdata = {
> +static struct bq24190_platform_data lenovo_yoga_tab2_1380_bq24190_pdata = {
>  	.regulator_init_data = &lenovo_yoga_tab2_1380_bq24190_vbus_init_data,
>  };
>  
> @@ -726,7 +726,7 @@ static const struct platform_device_info lenovo_yoga_tab2_1380_pdevs[] __initcon
>  	},
>  };
>  
> -const char * const lenovo_yoga_tab2_1380_modules[] __initconst = {
> +static const char * const lenovo_yoga_tab2_1380_modules[] __initconst = {
>  	"bq24190_charger",            /* For the Vbus regulator for lc824206xa */
>  	NULL
>  };