linux-kernel - Re: [PATCH livepatch/master v1 1/6] selftests/livepatch: fix test-callbacks.sh execution error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2411211414400.8938@pobox.suse.cz>
Date: Thu, 21 Nov 2024 14:16:43 +0100 (CET)
From: Miroslav Benes <mbenes@...e.cz>
To: George Guo <dongtai.guo@...ux.dev>
cc: jpoimboe@...nel.org, jikos@...nel.org, pmladek@...e.com, 
    joe.lawrence@...hat.com, shuah@...nel.org, live-patching@...r.kernel.org, 
    linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, 
    George Guo <guodongtai@...inos.cn>
Subject: Re: [PATCH livepatch/master v1 1/6] selftests/livepatch: fix
 test-callbacks.sh execution error

Hi,

On Thu, 21 Nov 2024, George Guo wrote:

> From: George Guo <guodongtai@...inos.cn>
> 
> The script test-callbacks.sh fails with the following error:
> $ sudo ./test-callbacks.sh
> TEST: target module before livepatch ... not ok
> 
> - expected
> + result
>  test_klp_callbacks_mod: test_klp_callbacks_mod_init
>  % insmod test_modules/test_klp_callbacks_demo.ko
>  livepatch: enabling patch 'test_klp_callbacks_demo'
> -livepatch: 'test_klp_callbacks_demo': initializing patching transition
> +transition: 'test_klp_callbacks_demo': initializing patching transition
>  test_klp_callbacks_demo: pre_patch_callback: vmlinux
>  test_klp_callbacks_demo: pre_patch_callback: test_klp_callbacks_mod -> [MODULE_STATE_LIVE] Normal state
> -livepatch: 'test_klp_callbacks_demo': starting patching transition
> -livepatch: 'test_klp_callbacks_demo': completing patching transition
> +transition: 'test_klp_callbacks_demo': starting patching transition
> +transition: 'test_klp_callbacks_demo': completing patching transition
>  test_klp_callbacks_demo: post_patch_callback: vmlinux
>  test_klp_callbacks_demo: post_patch_callback: test_klp_callbacks_mod -> [MODULE_STATE_LIVE] Normal state
> -livepatch: 'test_klp_callbacks_demo': patching complete
> +transition: 'test_klp_callbacks_demo': patching complete
>  % echo 0 > /sys/kernel/livepatch/test_klp_callbacks_demo/enabled
> -livepatch: 'test_klp_callbacks_demo': initializing unpatching transition
> +transition: 'test_klp_callbacks_demo': initializing unpatching transition
>  test_klp_callbacks_demo: pre_unpatch_callback: vmlinux
>  test_klp_callbacks_demo: pre_unpatch_callback: test_klp_callbacks_mod -> [MODULE_STATE_LIVE] Normal state
> -livepatch: 'test_klp_callbacks_demo': starting unpatching transition
> -livepatch: 'test_klp_callbacks_demo': completing unpatching transition
> +transition: 'test_klp_callbacks_demo': starting unpatching transition
> +transition: 'test_klp_callbacks_demo': completing unpatching transition
>  test_klp_callbacks_demo: post_unpatch_callback: vmlinux
>  test_klp_callbacks_demo: post_unpatch_callback: test_klp_callbacks_mod -> [MODULE_STATE_LIVE] Normal state
> -livepatch: 'test_klp_callbacks_demo': unpatching complete
> +transition: 'test_klp_callbacks_demo': unpatching complete
>  % rmmod test_klp_callbacks_demo
>  % rmmod test_klp_callbacks_mod
>  test_klp_callbacks_mod: test_klp_callbacks_mod_exit
> 
> ERROR: livepatch kselftest(s) failed
> 
> The issue arises due to a mismatch in expected log output during livepatch
> transition. Specifically, the logs previously contained "livepatch:" but have
> now been updated to "transition:". This results in test failures when comparing
> the output with the expected values.
> 
> This patch updates the expected test output to reflect the new log format.

are you sure? I have just run livepatch selftests on v6.12 and everything 
was fine.

The above suggests that something happened to KBUILD_MODNAME in your case 
(which would also mean that the fix should be different). Could you 
verify or provide more information, please?

Miroslav