linux-kernel - Re: [PATCH] media: ov5640: fix get_light

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zz83Hh6gKCFkxWtI@kekkonen.localdomain>
Date: Thu, 21 Nov 2024 13:35:26 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Michal Simek <michal.simek@....com>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
	git@...inx.com, Sam Bobrowicz <sam@...te-embedded.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Steve Longerbeam <slongerbeam@...il.com>,
	"open list:V4L2 CAMERA SENSOR DRIVERS" <linux-media@...r.kernel.org>
Subject: Re: [PATCH] media: ov5640: fix get_light_freq on auto

Hi Michal,

On Thu, Nov 21, 2024 at 02:32:16PM +0100, Michal Simek wrote:
> From: Sam Bobrowicz <sam@...te-embedded.com>
> 
> Light frequency was not properly returned when in auto
> mode and the detected frequency was 60Hz.
> 
> Signed-off-by: Sam Bobrowicz <sam@...te-embedded.com>
> Signed-off-by: Michal Simek <michal.simek@....com>
> ---
> 
>  drivers/media/i2c/ov5640.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index c1d3fce4a7d3..8566bc2edde9 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
>  			light_freq = 50;
>  		} else {
>  			/* 60Hz */
> +			light_freq = 60;

Any idea where this issue was introduced?

It'd be good to add Fixes: and Cc: stable to this.

>  		}
>  	}
>  

-- 
Regards,

Sakari Ailus