linux-kernel - Re: [PATCH v1 1/1] kcsan: debugfs: Use krealloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zz9AtzWWXW_mgjR6@smile.fi.intel.com>
Date: Thu, 21 Nov 2024 16:16:23 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Marco Elver <elver@...gle.com>
Cc: kasan-dev@...glegroups.com, linux-kernel@...r.kernel.org,
	Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH v1 1/1] kcsan: debugfs: Use krealloc_array() to replace
 krealloc()

On Thu, Nov 21, 2024 at 03:11:41PM +0100, Marco Elver wrote:
> On Thu, 21 Nov 2024 at 15:04, Marco Elver <elver@...gle.com> wrote:
> > On Thu, 21 Nov 2024 at 14:58, Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> > >
> > > Use krealloc_array() to replace krealloc() with multiplication.
> > > krealloc_array() has multiply overflow check, which will be safer.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >
> > Reviewed-by: Marco Elver <elver@...gle.com>
> 
> Unreview.
> 
> > Do you have a tree to take this through? Otherwise I'll take it.
> 
> Whoops. We got rid of that krealloc() in 59458fa4ddb4 ("kcsan: Turn
> report_filterlist_lock into a raw_spinlock"). And the replacement
> kmalloc() is already a kmalloc_array(). I suppose this patch is
> therefore obsolete.

Ah, I made this on top of v6.12 + something most likely unrelated.

-- 
With Best Regards,
Andy Shevchenko