linux-kernel - Re: [PATCH 02/13] rasdaemon: cxl: Fix mismatch in region field's name with kernel DRAM trace event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241121151259.00006803@huawei.com>
Date: Thu, 21 Nov 2024 15:12:59 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: <shiju.jose@...wei.com>
CC: <linux-edac@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
	<mchehab@...nel.org>, <dave.jiang@...el.com>, <dan.j.williams@...el.com>,
	<alison.schofield@...el.com>, <nifan.cxl@...il.com>,
	<vishal.l.verma@...el.com>, <ira.weiny@...el.com>, <dave@...olabs.net>,
	<linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
	<tanxiaofei@...wei.com>, <prime.zeng@...ilicon.com>
Subject: Re: [PATCH 02/13] rasdaemon: cxl: Fix mismatch in region field's
 name with kernel DRAM trace event

On Wed, 20 Nov 2024 09:59:12 +0000
<shiju.jose@...wei.com> wrote:

> From: Shiju Jose <shiju.jose@...wei.com>
> 
> Fix mismatch in 'region' field's name with kernel DRAM trace event.
> 
> Fixes: ea224ad58b37 ("rasdaemon: CXL: Extract, log and record region info from cxl_general_media and cxl_dram events")
> 
No line break here (though this is rasdaemon so maybe kernel rules don't apply?)
> Signed-off-by: Shiju Jose <shiju.jose@...wei.com>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  ras-cxl-handler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ras-cxl-handler.c b/ras-cxl-handler.c
> index 8733b2b..7d4fc9f 100644
> --- a/ras-cxl-handler.c
> +++ b/ras-cxl-handler.c
> @@ -966,7 +966,7 @@ int ras_cxl_dram_event_handler(struct trace_seq *s,
>  	if (trace_seq_printf(s, "hpa:0x%llx ", (unsigned long long)ev.hpa) <= 0)
>  		return -1;
>  
> -	ev.region = tep_get_field_raw(s, event, "region", record, &len, 1);
> +	ev.region = tep_get_field_raw(s, event, "region_name", record, &len, 1);
>  	if (!ev.region)
>  		return -1;
>  	if (trace_seq_printf(s, "region:%s ", ev.region) <= 0)