linux-kernel - Re: [PATCH] can: dev: can_set_termination(): Allow gpio sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d67c890-6e9c-46e5-a22e-84d354a93026@kunbus.com>
Date: Thu, 21 Nov 2024 16:30:00 +0100
From: Lino Sanfilippo <l.sanfilippo@...bus.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Nicolai Buchwitz <nb@...i-net.de>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 n.buchwitz@...bus.com, p.rosenberger@...bus.com, stable@...r.kernel.org,
 linux-can@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: dev: can_set_termination(): Allow gpio sleep

On 21.11.24 16:25, Marc Kleine-Budde wrote:
> On 21.11.2024 16:17:53, Lino Sanfilippo wrote:
>>> On 21.11.2024 16:02:09, Nicolai Buchwitz wrote:
>>>> The current implementation of can_set_termination() sets the GPIO in a
>>>> context which cannot sleep. This is an issue if the GPIO controller can
>>>> sleep (e.g. since the concerning GPIO expander is connected via SPI or
>>>> I2C). Thus, if the termination resistor is set (eg. with ip link),
>>>> a warning splat will be issued in the kernel log.
>>>>
>>>> Fix this by setting the termination resistor with
>>>> gpiod_set_value_cansleep() which instead of gpiod_set_value() allows it to
>>>> sleep.
>>>>
>>>> Cc: stable@...r.kernel.org
>>>> Signed-off-by: Nicolai Buchwitz <nb@...i-net.de>
>>>
>>> I've send the same patch a few hours ago:
>>>
>>> https://lore.kernel.org/all/20241121-dev-fix-can_set_termination-v1-1-41fa6e29216d@pengutronix.de/
>>>
>> Shouldnt this also go to stable?
> 
> Until today no-one complained about the problem, but I'll add stable on
> Cc while applying the patch.
> 
> regards,
> Marc
> 

Great, thanks!

BR,
Lino