linux-kernel - Re: [PATCH] bpftool: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e2e589b-4ddd-411e-a1a7-a2caf9689417@kernel.org>
Date: Thu, 21 Nov 2024 15:35:29 +0000
From: Quentin Monnet <qmo@...nel.org>
To: Alexis Lothoré <alexis.lothore@...tlin.com>,
 liujing <liujing@...s.chinamobile.com>, daniel@...earbox.net,
 andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpftool: Fix the wrong format specifier

2024-11-21 13:43 UTC+0100 ~ Alexis Lothoré <alexis.lothore@...tlin.com>
> Hi Liujing,
> 
> On 11/21/24 13:17, liujing wrote:
>> The type of lines is unsigned int, so the correct format specifier should be
>> %u instead of %d.
>>
>> Signed-off-by: liujing <liujing@...s.chinamobile.com>
>>
>> V1 -> V2: Fixed two other wrong type outputs about lines
> 
> This commit changelog line should not appear in the commit message. This is
> still useful for review though, so you can keep it in the commit by using a ---
> separator (see other patches on the ML), which will make it automatically
> trimmed when the maintainers will apply the patch.

Also next time please remember to tag your patch as "v2" in the email
subject.

Patch looks good, thank you!

Reviewed-by: Quentin Monnet <qmo@...nel.org>