linux-kernel - Re: [PATCH] drm/amd/pm: Fix an error handling path in vega10_enable_se_edc_force_stall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_ONUa=8g6qKqFHDeiNNeJ7QidyReGhNYoxBzPX7B36EJg@mail.gmail.com>
Date: Thu, 21 Nov 2024 10:42:06 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Kenneth Feng <kenneth.feng@....com>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Evan Quan <evan.quan@....com>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/amd/pm: Fix an error handling path in vega10_enable_se_edc_force_stall_config()

Applied.  Thanks!

Alex

On Tue, Nov 19, 2024 at 4:02 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> In case of error after a amdgpu_gfx_rlc_enter_safe_mode() call, it is not
> balanced by a corresponding amdgpu_gfx_rlc_exit_safe_mode() call.
>
> Add the missing call.
>
> Fixes: 9b7b8154cdb8 ("drm/amd/powerplay: added didt support for vega10")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> *Not* even compile tested only because of missing "hwmgr.h". I've not
> checked on which arch it is supposed to run in order to cross-compile.
>
> This patch is speculative, review with care!
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_powertune.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_powertune.c
> index 3007b054c873..776d58ea63ae 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_powertune.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_powertune.c
> @@ -1120,13 +1120,14 @@ static int vega10_enable_se_edc_force_stall_config(struct pp_hwmgr *hwmgr)
>         result = vega10_program_didt_config_registers(hwmgr, SEEDCForceStallPatternConfig_Vega10, VEGA10_CONFIGREG_DIDT);
>         result |= vega10_program_didt_config_registers(hwmgr, SEEDCCtrlForceStallConfig_Vega10, VEGA10_CONFIGREG_DIDT);
>         if (0 != result)
> -               return result;
> +               goto exit_safe_mode;
>
>         vega10_didt_set_mask(hwmgr, false);
>
> +exit_safe_mode:
>         amdgpu_gfx_rlc_exit_safe_mode(adev, 0);
>
> -       return 0;
> +       return result;
>  }
>
>  static int vega10_disable_se_edc_force_stall_config(struct pp_hwmgr *hwmgr)
> --
> 2.47.0
>