linux-kernel - Re: [PATCH] tools/power/x86/intel-speed-select: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56b6520093f5a0aca6738d2114c5ae08db2660fa.camel@linux.intel.com>
Date: Thu, 21 Nov 2024 08:49:01 -0800
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: liujing <liujing@...s.chinamobile.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Fix the wrong
 format specifier

On Thu, 2024-11-21 at 21:00 +0800, liujing wrote:
> Because clos_config->clos_min and clos_config->clos_max
> are unsigned int types, the output format should be %u.
> 
> Signed-off-by: liujing <liujing@...s.chinamobile.com>

You need to have for your tag:

Full Name <email address>

Thanks,
Srinivas

> 
> diff --git a/tools/power/x86/intel-speed-select/isst-display.c
> b/tools/power/x86/intel-speed-select/isst-display.c
> index 07ebd08f3202..5ecf24bda6dd 100644
> --- a/tools/power/x86/intel-speed-select/isst-display.c
> +++ b/tools/power/x86/intel-speed-select/isst-display.c
> @@ -617,14 +617,14 @@ void isst_clos_display_information(struct
> isst_id *id, FILE *outf, int clos,
>  	format_and_print(outf, level + 2, header, value);
>  
>  	snprintf(header, sizeof(header), "clos-min");
> -	snprintf(value, sizeof(value), "%d MHz", clos_config-
> >clos_min * isst_get_disp_freq_multiplier());
> +	snprintf(value, sizeof(value), "%u MHz", clos_config-
> >clos_min * isst_get_disp_freq_multiplier());
>  	format_and_print(outf, level + 2, header, value);
>  
>  	snprintf(header, sizeof(header), "clos-max");
>  	if ((clos_config->clos_max *
> isst_get_disp_freq_multiplier()) == 25500)
>  		snprintf(value, sizeof(value), "Max Turbo
> frequency");
>  	else
> -		snprintf(value, sizeof(value), "%d MHz",
> clos_config->clos_max * isst_get_disp_freq_multiplier());
> +		snprintf(value, sizeof(value), "%u MHz",
> clos_config->clos_max * isst_get_disp_freq_multiplier());
>  	format_and_print(outf, level + 2, header, value);
>  
>  	snprintf(header, sizeof(header), "clos-desired");