linux-kernel - Re: [PATCH v9 1/9] x86/resctrl: Introduce resctrl_file_fflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zz9sNkBj3Mpv2vO4@agluck-desk3>
Date: Thu, 21 Nov 2024 09:21:58 -0800
From: "Luck, Tony" <tony.luck@...el.com>
To: Reinette Chatre <reinette.chatre@...el.com>
Cc: Fenghua Yu <fenghua.yu@...el.com>,
	Peter Newman <peternewman@...gle.com>,
	Jonathan Corbet <corbet@....net>, x86@...nel.org,
	James Morse <james.morse@....com>,
	Jamie Iles <quic_jiles@...cinc.com>,
	Babu Moger <babu.moger@....com>,
	Randy Dunlap <rdunlap@...radead.org>,
	"Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	patches@...ts.linux.dev
Subject: Re: [PATCH v9 1/9] x86/resctrl: Introduce resctrl_file_fflags_init()
 to initialize fflags

On Tue, Nov 19, 2024 at 04:38:15PM -0800, Reinette Chatre wrote:
> Hi Tony,
> 
> On 11/13/24 4:17 PM, Tony Luck wrote:
> > From: Babu Moger <babu.moger@....com>
> > 
> > thread_throttle_mode_init() and mbm_config_rftype_init() both initialize
> > fflags for resctrl files.
> > 
> > Adding new files will involve adding another function to initialize
> > the fflags. This can be simplified by adding a new function
> > resctrl_file_fflags_init() and passing the file name and flags
> > to be initialized.
> > 
> > Consolidate fflags initialization into resctrl_file_fflags_init() and
> > remove thread_throttle_mode_init() and mbm_config_rftype_init().
> > 
> > Signed-off-by: Babu Moger <babu.moger@....com>
> > Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
> > Signed-off-by: Tony Luck <tony.luck@...el.com>
> 
> Please place "Signed-off-by" tag before "Reviewed-by" tag. For reference,
> "Ordering of commit tags" in Documentation/process/maintainer-tip.rst

Hi Reinette,

I had misremembered what that Documentation file said. There is a
section that describes keeping the Signed-off-by: tags in the order
they were applied so that the commit comment describes the path that
the patch took before final acceptance. I thought that ordering applied
to other tags.

But while I was there refreshing my memory I also noted the section
about documenting changes made when adopting patches from other
people. So I've added:

[Tony: Drop __init attribute so resctrl_file_fflags_init() can be used
at run time]
> 
> Reinette

-Tony