linux-kernel - Re: [PATCH] arm64: disable ARCH_CORRECT_STACKTRACE_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173221694242.390240.12306680698453955259.b4-ty@arm.com>
Date: Thu, 21 Nov 2024 19:22:29 +0000
From: Catalin Marinas <catalin.marinas@....com>
To: linux-arm-kernel@...ts.infradead.org,
	Mark Rutland <mark.rutland@....com>
Cc: Will Deacon <will@...nel.org>,
	ardb@...nel.org,
	broonie@...nel.org,
	jpoimboe@...nel.org,
	kaleshsingh@...gle.com,
	kristina.martsenko@....com,
	linux-kernel@...r.kernel.org,
	madvenka@...ux.microsoft.com,
	maz@...nel.org,
	mbenes@...e.cz,
	mhiramat@...nel.org,
	rostedt@...dmis.org,
	Puranjay Mohan <puranjay@...nel.org>
Subject: Re: [PATCH] arm64: disable ARCH_CORRECT_STACKTRACE_ON_KRETPROBE tests

On Mon, 18 Nov 2024 12:02:04 +0000, Mark Rutland wrote:
> The kprobes_test suite's test_stacktrace_on_nested_kretprobe() test
> currently fails on arm64, e.g.
> 
> | KTAP version 1
> | 1..1
> |     KTAP version 1
> |     # Subtest: kprobes_test
> |     # module: test_kprobes
> |     1..7
> |     ok 1 test_kprobe
> |     ok 2 test_kprobes
> |     ok 3 test_kprobe_missed
> |     ok 4 test_kretprobe
> |     ok 5 test_kretprobes
> |     ok 6 test_stacktrace_on_kretprobe
> |     # test_stacktrace_on_nested_kretprobe: EXPECTATION FAILED at lib/test_kprobes.c:327
> |     Expected stack_buf[i + 1] == target_return_address[1], but
> |         stack_buf[i + 1] == -96519936577004 (0xffffa83733777214)
> |         target_return_address[1] == -96519936577136 (0xffffa83733777190)
> |     # test_stacktrace_on_nested_kretprobe: EXPECTATION FAILED at lib/test_kprobes.c:338
> |     Expected stack_buf[1] == target_return_address[1], but
> |         stack_buf[1] == -96519936577004 (0xffffa83733777214)
> |         target_return_address[1] == -96519936577136 (0xffffa83733777190)
> |     not ok 7 test_stacktrace_on_nested_kretprobe
> | # kprobes_test: pass:6 fail:1 skip:0 total:7
> | # Totals: pass:6 fail:1 skip:0 total:7
> | not ok 1 kprobes_test
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: disable ARCH_CORRECT_STACKTRACE_ON_KRETPROBE tests
      https://git.kernel.org/arm64/c/a63d7408afbd

-- 
Catalin