linux-kernel - Re: [PATCH v2] iio: hid-sensor-prox: Fix invalid read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d164919c9290ca1410bc21746511799a5c17b94d.camel@linux.intel.com>
Date: Fri, 22 Nov 2024 09:55:04 -0800
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Ricardo Ribalda <ribalda@...omium.org>, Jiri Kosina <jikos@...nel.org>, 
 Jonathan Cameron
	 <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	linux-input@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: hid-sensor-prox: Fix invalid read_raw for
 attention

On Fri, 2024-11-22 at 17:36 +0000, Ricardo Ribalda wrote:
> The attention channel is a IIO_CHAN_INFO_PROCESSED, not a
> IIO_CHAN_INFO_RAW.
> 
> Modify prox_read_raw() to support it.
> 
> Fixes: 596ef5cf654b ("iio: hid-sensor-prox: Add support for more
> channels")
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
> Changes in v2:
> - Do not change the condition for applying the multiplier.
> - Link to v1:
> https://lore.kernel.org/r/20241121-fix-processed-v1-1-4fae6770db30@chromium.org
> ---
>  drivers/iio/light/hid-sensor-prox.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/light/hid-sensor-prox.c
> b/drivers/iio/light/hid-sensor-prox.c
> index e8e7b2999b4c..0daa8d365a6c 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -94,6 +94,7 @@ static int prox_read_raw(struct iio_dev *indio_dev,
>  	*val2 = 0;
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
> +	case IIO_CHAN_INFO_PROCESSED:
>  		if (chan->scan_index >= prox_state->num_channels)
>  			return -EINVAL;
>  		address = prox_state->channel2usage[chan-
> >scan_index];
> 
> ---
> base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
> change-id: 20241121-fix-processed-ed1a95641e64
> 
> Best regards,